Page MenuHomePhabricator

Add modules downloaded by ModuleCache to the global ModuleList
ClosedPublic

Authored by tberghammer on Dec 10 2015, 6:29 AM.

Details

Summary

Add modules downloaded by ModuleCache to the global ModuleList

Adding the modules to the global module list eliminate issues in the
case when a module is unloaded from the target but some object (e.g.
breakpoint) still referencing them with weak pointers. It also speeds
up the case when we load, unload, load the same shared library because
the global module cache will keep the parsed debug info around between
the 2 load (this scenario happens for some code on android).

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Add modules downloaded by ModuleCache to the global ModuleList.
tberghammer updated this object.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
ovyalov accepted this revision.Dec 10 2015, 9:06 AM
ovyalov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 10 2015, 9:06 AM
This revision was automatically updated to reflect the committed changes.