This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] Move several .fail.cpp tests to .verify.cpp
ClosedPublic

Authored by ldionne on Jun 16 2023, 8:48 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGdc71a77d3362: [libc++][NFC] Move several .fail.cpp tests to .verify.cpp
Summary

A few tests were also straightforward to translate to SFINAE tests
instead, so in a few cases I did that and removed the .fail.cpp test
entirely.

Diff Detail

Event Timeline

ldionne created this revision.Jun 16 2023, 8:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2023, 8:48 AM
ldionne requested review of this revision.Jun 16 2023, 8:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2023, 8:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 532190.Jun 16 2023, 9:14 AM

Fix CI issue

ldionne updated this revision to Diff 532236.Jun 16 2023, 10:56 AM

Add missing include

ldionne accepted this revision as: Restricted Project.Jun 19 2023, 6:06 AM

Bootstrapping build failure is seen in other runs and is unrelated to the change.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2023, 6:06 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
libcxx/test/std/containers/views/views.span/span.cons/array.pass.cpp