This is an archive of the discontinued LLVM Phabricator instance.

hwasan: refactor order of macros in hwasan_platform_interceptors.h [NFC]
ClosedPublic

Authored by thurston on May 24 2023, 1:19 PM.

Details

Summary

Currently, the header file contains all the undefs, followed by all the
define X 0. This will be inconvenient for re-enabling interceptors,
because we would need to comment out (or delete) the corresponding macros
in two different places.

This patch groups together the macros for each function.

Additionally, it adds the suggestion that interceptors should be
re-enabled by commenting out (not deleting) the macros.

Diff Detail

Event Timeline

thurston created this revision.May 24 2023, 1:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 1:19 PM
Herald added a subscriber: Enna1. · View Herald Transcript
thurston requested review of this revision.May 24 2023, 1:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 1:19 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka accepted this revision.May 24 2023, 5:02 PM
This revision is now accepted and ready to land.May 24 2023, 5:02 PM
vitalybuka added inline comments.May 24 2023, 5:03 PM
compiler-rt/lib/hwasan/hwasan_platform_interceptors.h
14

why do we want to keep them commented?

This revision was landed with ongoing or failed builds.May 24 2023, 5:22 PM
This revision was automatically updated to reflect the committed changes.