This is an archive of the discontinued LLVM Phabricator instance.

Finish the job of D145569
ClosedPublic

Authored by jingham on Apr 27 2023, 5:25 PM.

Details

Summary

The InstrumentationRuntime's defined a data structure to gather report data, and repeated the pattern of defining it like:

struct data {
};
data t = {0};

That causes conflicts against other types called data, and could cause the expression not to compile. Michael fixed this for some of the sanitizers in:

https://reviews.llvm.org/D145569

but neglected to do it for the thread sanitizer.

This patch adds the fix to that sanitizer.

Diff Detail

Event Timeline

jingham created this revision.Apr 27 2023, 5:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 5:25 PM
jingham requested review of this revision.Apr 27 2023, 5:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 5:25 PM
Michael137 accepted this revision.Apr 27 2023, 5:29 PM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 27 2023, 5:29 PM
This revision was landed with ongoing or failed builds.Apr 27 2023, 5:39 PM
This revision was automatically updated to reflect the committed changes.