This is an archive of the discontinued LLVM Phabricator instance.

Differential D148961

[clang] Remove unnecessary virtual inheritance in `TargetInfo`
ClosedPublic

Authored by Stoorx on Apr 21 2023, 2:09 PM.

Details

Reviewers
phosek
Commits
rG368112e2024a: [clang] Remove unnecessary virtual inheritance in `TargetInfo`
Summary

Since the TargetInfo has no diamond-like inheritance diagram,
the virtual keyword is not necessary.

Diff Detail

Event Timeline

Stoorx created this revision.Apr 21 2023, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 2:09 PM
Stoorx requested review of this revision.Apr 21 2023, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 2:09 PM
Stoorx added a reviewer: phosek.Apr 21 2023, 2:09 PM
phosek accepted this revision.Apr 21 2023, 3:02 PM

LGTM

This revision is now accepted and ready to land.Apr 21 2023, 3:02 PM
Harbormaster completed remote builds in B227325: Diff 515912.Apr 21 2023, 5:16 PM
Closed by commit rG368112e2024a: [clang] Remove unnecessary virtual inheritance in `TargetInfo` (authored by Stoorx). · Explain WhyApr 24 2023, 2:15 AM
This revision was automatically updated to reflect the committed changes.
Stoorx added a commit: rG368112e2024a: [clang] Remove unnecessary virtual inheritance in `TargetInfo`.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
2 lines

Diff 516317

clang/include/clang/Basic/TargetInfo.h

Show First 20 Lines • Show All 196 Lines • ▼ Show 20 Linesenum OpenCLTypeKind : uint8_t {
OCLTK_Pipe, OCLTK_Pipe,
OCLTK_Queue, OCLTK_Queue,
OCLTK_ReserveID, OCLTK_ReserveID,
OCLTK_Sampler, OCLTK_Sampler,
}; };
/// Exposes information about the current target. /// Exposes information about the current target.
/// ///
class TargetInfo : public virtual TransferrableTargetInfo, class TargetInfo : public TransferrableTargetInfo,
public RefCountedBase<TargetInfo> { public RefCountedBase<TargetInfo> {
std::shared_ptr<TargetOptions> TargetOpts; std::shared_ptr<TargetOptions> TargetOpts;
llvm::Triple Triple; llvm::Triple Triple;
protected: protected:
// Target values set by the ctor of the actual target implementation. Default // Target values set by the ctor of the actual target implementation. Default
// values are specified by the TargetInfo constructor. // values are specified by the TargetInfo constructor.
bool BigEndian; bool BigEndian;
bool TLSSupported; bool TLSSupported;
▲ Show 20 Lines • Show All 1,520 Lines • Show Last 20 Lines