This is an archive of the discontinued LLVM Phabricator instance.

Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes
ClosedPublic

Authored by tfiala on Nov 18 2015, 11:47 AM.

Details

Reviewers
zturner
Summary

These classes have been cleaned up in scripts/prepare_bindings.py and scripts/Python/prepare_binding_Python.py.

Both Xcode and cmake builds have been converted over.

Waiting to make sure this works for Windows, which has a few places where it does something different than the POSIX bits.

Diff Detail

Event Timeline

tfiala updated this revision to Diff 40536.Nov 18 2015, 11:47 AM
tfiala retitled this revision from to Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes .
tfiala updated this object.
tfiala added a reviewer: zturner.
tfiala added a subscriber: lldb-commits.

Looks like with your change in r253501, we are okay to delete these?

zturner accepted this revision.Nov 18 2015, 1:43 PM
zturner edited edge metadata.

As long as with your new script these are no longer being called anywhere, should be safe to remove.

This revision is now accepted and ready to land.Nov 18 2015, 1:43 PM

Okay, thanks. I'll grep the source base first to make sure I'm not missing anything else.

tfiala updated this revision to Diff 40560.Nov 18 2015, 2:14 PM
tfiala edited edge metadata.

Missed one reference in a cmake custom command dependency. Fixed in latest diff.

Aside from that one fix in the second patch, a grep for those two scripts came back clean on the source tree.

tfiala closed this revision.Nov 18 2015, 2:25 PM

Committed here:
r253513.

sounds good