This is an archive of the discontinued LLVM Phabricator instance.

Include a clearer policy about what's ok/nok to speed up code reviews.
ClosedPublic

Authored by klimek on Aug 22 2013, 6:01 AM.

Details

Reviewers
klimek
Summary

As this seems to be one of the recurring themes (albeit luckily
enough not too often), trying to put up a helpful policy.

Diff Detail

Event Timeline

Might be worth calling out the 'common courtesy' ping rate for
non-specially-urgent patches which is generally accepted at 1 week.

LGTM, just some copy-editing.

docs/DeveloperPolicy.rst
138–139

Leading cap and trailing dot. I'd also split each of the bullets into two sentences:

  • Review other people's patches. If you help out, ... our currency.
klimek updated this revision to Unknown Object (????).Aug 23 2013, 1:50 AM

Some rewording based on feedback.

klimek accepted this revision.Aug 26 2013, 12:32 AM
klimek closed this revision.

Thx. Submitted as r189210.