This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Reintroduce workaround for stdint re-export on Darwin
ClosedPublic

Authored by ldionne on Mar 1 2023, 1:50 PM.

Details

Summary

This had been removed as part of 3a0f88c4c2c4. It turns out that this
did break some code, but we never noticed because it requires including
<stdint.h> (and nothing else), and then using one of the types from
that header. It also requires running with modules enabled in a Standard
no later than C++17.

After the test refactorings in D145116, this bug would be caught
by running a CI job on macOS with modules enabled in C++17 mode
(but surprisingly not with more recent standards). This patch doesn't
add such a job because it is deemed a corner case.

Diff Detail

Event Timeline

ldionne created this revision.Mar 1 2023, 1:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 1:50 PM
ldionne requested review of this revision.Mar 1 2023, 1:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 1:50 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Mar 2 2023, 9:38 AM
This revision is now accepted and ready to land.Mar 2 2023, 9:38 AM