Page MenuHomePhabricator

[swig] Simplify check_lldb_swig_executable_file_exists.
ClosedPublic

Authored by brucem on Nov 5 2015, 8:22 PM.

Details

Summary

Remove per-platform variants of this in favor of just having
Windows and Unix. The code that was previously specific to
Linux can be further simplified and used on all non-Windows
platforms that are currently supported as build hosts.

This code only runs when --swigExecutable isn't given on the
command line. cmake always passes that in, so this is never
actually used in current practice.

Diff Detail

Repository
rL LLVM

Event Timeline

brucem updated this revision to Diff 39471.Nov 5 2015, 8:22 PM
brucem retitled this revision from to [swig] Simplify check_lldb_swig_executable_file_exists..
brucem updated this object.
brucem added reviewers: zturner, domipheus.
brucem added a subscriber: lldb-commits.
zturner edited edge metadata.Nov 6 2015, 9:40 AM

If it's never used in practice, can you just delete the codepath entirely? I'm a strong proponent of deleting code that nobody cares about. (Of course, if you found this because you do care about it and this codepath didn't work when you tried to use it, that's a different story)

Well, I'm pretty sure ... but I don't know if someone in some configuration or set of build arrangements might use it. It might also be used if we ever make the Makefiles or xcode projects use these scripts.

Eh, just delete it IMO. I don't like leaving code around "just in case". These scripts already need to be practically re-written (due to not using the standard argparse module), the less work we have to do the better. CMake is the only user of this script as far as I know. If it breaks someone they'll chime in presumably

brucem updated this revision to Diff 39558.Nov 6 2015, 10:41 AM
brucem edited edge metadata.

Instead of simplifying, just remove. Expand scope of removal as well.

zturner accepted this revision.Nov 6 2015, 10:45 AM
zturner edited edge metadata.
This revision is now accepted and ready to land.Nov 6 2015, 10:45 AM
This revision was automatically updated to reflect the committed changes.