Page MenuHomePhabricator

Enable the libc++ tests on linux
ClosedPublic

Authored by labath on Oct 22 2015, 7:48 AM.

Details

Summary

The list of loaded modules which skip_if_library_missing is depending on is not available on
linux until after we run the target. This causes the tests to be wrongfully skipped. This commit
moves the skip call after the run command.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 38129.Oct 22 2015, 7:48 AM
labath retitled this revision from to Enable the libc++ tests on linux.
labath updated this object.
labath added reviewers: granata.enrico, tfiala.
labath added a subscriber: lldb-commits.
tfiala accepted this revision.Oct 22 2015, 8:06 AM
tfiala edited edge metadata.

LGTM. Good catch!

This revision is now accepted and ready to land.Oct 22 2015, 8:06 AM

(I don't think you need to wait for Enrico, btw.)

This revision was automatically updated to reflect the committed changes.