This is an archive of the discontinued LLVM Phabricator instance.

[LoopUnswitch] Correct misleading comments.
ClosedPublic

Authored by • chenli on Oct 14 2015, 12:18 PM.

Reviewers

reames

Commits

• chenli retitled this revision from to [LoopUnswitch] Correct misleading comments..

• chenli updated this object.

• chenli added a reviewer: reames.

LGTM

This revision is now accepted and ready to land.Oct 14 2015, 12:27 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Transforms/

Scalar/

3 lines

Show First 20 Lines • Show All 481 Lines • ▼ Show 20 Lines	if (!currentLoop->isSafeToClone())
return false;		return false;

// Without dedicated exits, splitting the exit edge may fail.		// Without dedicated exits, splitting the exit edge may fail.
if (!currentLoop->hasDedicatedExits())		if (!currentLoop->hasDedicatedExits())
return false;		return false;

LLVMContext &Context = loopHeader->getContext();		LLVMContext &Context = loopHeader->getContext();

// Probably we reach the quota of branches for this loop. If so		// Analyze loop cost, and stop unswitching if loop content can not be duplicated.
// stop unswitching.
if (!BranchesInfo.countLoop(		if (!BranchesInfo.countLoop(
currentLoop, getAnalysis<TargetTransformInfoWrapperPass>().getTTI(		currentLoop, getAnalysis<TargetTransformInfoWrapperPass>().getTTI(
*currentLoop->getHeader()->getParent()),		*currentLoop->getHeader()->getParent()),
AC))		AC))
return false;		return false;

// Try trivial unswitch first before loop over other basic blocks in the loop.		// Try trivial unswitch first before loop over other basic blocks in the loop.
if (TryTrivialLoopUnswitch(Changed)) {		if (TryTrivialLoopUnswitch(Changed)) {
▲ Show 20 Lines • Show All 845 Lines • Show Last 20 Lines