This is an archive of the discontinued LLVM Phabricator instance.

Differential D136608

[lldb-tests] Remove libstdc++ requirement from test
ClosedPublic

Authored by fdeazeve on Oct 24 2022, 8:11 AM.

Details

Reviewers
Michael137
Commits
rG73200d155a58: [lldb-tests] Remove libstdc++ requirement from test
Summary

This requirement dates back to ten years ago and the test seems to work
nowadays with either libc++ or libstdc++.

Diff Detail

Event Timeline

fdeazeve created this revision.Oct 24 2022, 8:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 8:11 AM
fdeazeve requested review of this revision.Oct 24 2022, 8:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 8:11 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B193946: Diff 470164.Oct 24 2022, 8:11 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptOct 24 2022, 8:11 AM
fdeazeve updated this revision to Diff 470165.Oct 24 2022, 8:14 AM

Rebased

Michael137 accepted this revision.Oct 24 2022, 8:16 AM
This revision is now accepted and ready to land.Oct 24 2022, 8:16 AM
Harbormaster completed remote builds in B193947: Diff 470165.Oct 24 2022, 8:17 AM
Closed by commit rG73200d155a58: [lldb-tests] Remove libstdc++ requirement from test (authored by fdeazeve). · Explain WhyOct 24 2022, 9:30 AM
This revision was automatically updated to reflect the committed changes.
fdeazeve added a commit: rG73200d155a58: [lldb-tests] Remove libstdc++ requirement from test.

Revision Contents

PathSize
lldb/
test/
API/
functionalities/
data-formatter/
data-formatter-skip-summary/
3 lines

Diff 470186

lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
USE_LIBSTDCPP := 0
CXXFLAGS_EXTRAS := -O0 CXXFLAGS_EXTRAS := -O0
include Makefile.rules include Makefile.rules