Page MenuHomePhabricator

[clang-tidy] Update documentation of readability-inconsistent-declaration-parameter-names
ClosedPublic

Authored by piotrdz on Oct 11 2015, 4:43 AM.

Details

Summary

I forgot to update the documentation after the final rework of code that was committed.

Diff Detail

Event Timeline

piotrdz updated this revision to Diff 37053.Oct 11 2015, 4:43 AM
piotrdz retitled this revision from to [clang-tidy] Update documentation of readability-inconsistent-declaration-parameter-names.
piotrdz updated this object.
piotrdz added a reviewer: alexfh.
aaron.ballman accepted this revision.Oct 13 2015, 9:00 AM
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a subscriber: aaron.ballman.

With some minor grammatical changes, this LGTM!

~Aaron

docs/clang-tidy/checks/readability-inconsistent-declaration-parameter-name.rst
32

"to a single"

33

"that the function"

41

"In the case"

43

"seen in a translation"

This revision is now accepted and ready to land.Oct 13 2015, 9:00 AM
piotrdz updated this revision to Diff 37273.Oct 13 2015, 11:07 AM
piotrdz marked 4 inline comments as done.

Addressed issues found in review

@aaron.ballman: Thanks for the review. I uploaded an updated diff with fixes.

LGTM! Do you have commit privileges, or would you like me to commit on your behalf?

docs/clang-tidy/checks/readability-inconsistent-declaration-parameter-name.rst
44

Uncertain how much RST cares about this, but the previous file ended in a newline, so the current one likely should as well.

Ah, no, I don't - so far I have relied on other people to help with commits. I'd appreciate it if you could commit this for me. Thanks.

I have commit in r250194; thank you!

~Aaron