This is an archive of the discontinued LLVM Phabricator instance.

Raise timeout for Solaris builders
ClosedPublic

Authored by ro on Jul 17 2022, 2:02 AM.

Details

Summary

As described in D129837, the Solaris builders (solaris11-amd64 in particular) suffer from a procfs bug that causes long runtimes for some sanitizer tests, which eventually get killed after the default timeout of 1200 s. As a workaround, this patch increases the timeout to allow them to finish.

Diff Detail

Event Timeline

ro created this revision.Jul 17 2022, 2:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2022, 2:02 AM
ro requested review of this revision.Jul 17 2022, 2:02 AM
This revision is now accepted and ready to land.Jul 17 2022, 10:19 AM
This revision was automatically updated to reflect the committed changes.

Hi Rainer,
Are you about to propose a patch to implement timeout support in ClangBuilder?

ro added a comment.Jul 18 2022, 11:12 AM

TBH, I hadn't been aware that I needed to. Looking at AnnotatedBuilder.py and AOSPBuilder.py, I see now what's necessary. Patch coming, although I won't be able to test it.

That’s fine. The usage is in the staging, and your builders fail otherwise, so we will test it in action.
But please make sure the current behavior is preserved if timeout is not specified explicitly.