This is an archive of the discontinued LLVM Phabricator instance.

Return false, not 0, for bools.
ClosedPublic

Authored by brucem on Sep 14 2015, 9:52 PM.

Reviewers

sas
clayborg

Commits

brucem retitled this revision from to Return false, not 0, for bools..

brucem updated this object.

brucem added a reviewer: clayborg.

brucem added a subscriber: lldb-commits.

sas accepted this revision.Sep 15 2015, 2:08 PM

sas added a reviewer: sas.

This revision is now accepted and ready to land.Sep 15 2015, 2:08 PM

clayborg edited edge metadata.

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

Symbol/

2 lines

2 lines

Show First 20 Lines • Show All 2,443 Lines • ▼ Show 20 Lines	switch (type_class)
is_incomplete);		is_incomplete);
}		}
if (element_type_ptr)		if (element_type_ptr)
element_type_ptr->Clear();		element_type_ptr->Clear();
if (size)		if (size)
*size = 0;		*size = 0;
if (is_incomplete)		if (is_incomplete)
*is_incomplete = false;		*is_incomplete = false;
return 0;		return false;
}		}

bool		bool
ClangASTContext::IsVectorType (void* type,		ClangASTContext::IsVectorType (void* type,
CompilerType *element_type,		CompilerType *element_type,
uint64_t *size)		uint64_t *size)
{		{
clang::QualType qual_type (GetCanonicalQualType(type));		clang::QualType qual_type (GetCanonicalQualType(type));
▲ Show 20 Lines • Show All 6,484 Lines • Show Last 20 Lines

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines	if (IsValid())
return m_type_system->IsArrayType(m_type, element_type_ptr, size, is_incomplete);		return m_type_system->IsArrayType(m_type, element_type_ptr, size, is_incomplete);

if (element_type_ptr)		if (element_type_ptr)
element_type_ptr->Clear();		element_type_ptr->Clear();
if (size)		if (size)
*size = 0;		*size = 0;
if (is_incomplete)		if (is_incomplete)
*is_incomplete = false;		*is_incomplete = false;
return 0;		return false;
}		}

bool		bool
CompilerType::IsVectorType (CompilerType *element_type,		CompilerType::IsVectorType (CompilerType *element_type,
uint64_t *size) const		uint64_t *size) const
{		{
if (IsValid())		if (IsValid())
return m_type_system->IsVectorType(m_type, element_type, size);		return m_type_system->IsVectorType(m_type, element_type, size);
▲ Show 20 Lines • Show All 1,136 Lines • Show Last 20 Lines