This is an archive of the discontinued LLVM Phabricator instance.

Differential D125586

Fix broken SFINAE in std::__copy for trivially copyable types.
AbandonedPublic

Authored by dcheng on May 13 2022, 2:56 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

With the broken SFINAE, std::copy will never use memmove, even for
trivially copyable types.

Diff Detail

Event Timeline

dcheng created this revision.May 13 2022, 2:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 2:56 PM
dcheng requested review of this revision.May 13 2022, 2:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 2:56 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik added a subscriber: philnik.May 13 2022, 2:58 PM

See D124328.

Harbormaster completed remote builds in B164399: Diff 429362.May 13 2022, 3:01 PM
dcheng abandoned this revision.May 13 2022, 3:05 PM

D124328 fixes this and a few other things.

Revision Contents

PathSize
libcxx/
include/
__algorithm/
15 lines

Diff 429362

libcxx/include/__algorithm/copy.h

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
template <class _InIter, class _Sent, class _OutIter> template <class _InIter, class _Sent, class _OutIter>
inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11 inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11
pair<_InIter, _OutIter> __copy(_InIter __first, _Sent __last, _OutIter __result) { pair<_InIter, _OutIter> __copy(_InIter __first, _Sent __last, _OutIter __result) {
return std::__copy_impl(std::move(__first), std::move(__last), std::move(__result)); return std::__copy_impl(std::move(__first), std::move(__last), std::move(__result));
} }
template <class _InIter, class _Sent, class _OutIter, template <class _InIter, class _Sent, class _OutIter,
__enable_if_t<is_copy_constructible<_InIter>::value class __enable_if_t<is_copy_constructible<_InIter>::value && is_copy_constructible<_Sent>::value &&
&& is_copy_constructible<_Sent>::value is_copy_constructible<_OutIter>::value> >
&& is_copy_constructible<_OutIter>::value> > inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11 pair<_InIter, _OutIter> __copy(_InIter __first, _Sent __last,
inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11 _OutIter __result) {
pair<_InIter, _OutIter> __copy(_InIter __first, _Sent __last, _OutIter __result) {
auto __ret = std::__copy_impl(std::__unwrap_iter(__first), std::__unwrap_iter(__last), std::__unwrap_iter(__result)); auto __ret = std::__copy_impl(std::__unwrap_iter(__first), std::__unwrap_iter(__last), std::__unwrap_iter(__result));
return std::make_pair(std::__rewrap_iter(__first, __ret.first), std::__rewrap_iter(__result, __ret.second)); return std::make_pair(std::__rewrap_iter(__first, __ret.first), std::__rewrap_iter(__result, __ret.second));
} }
template <class _InputIterator, class _OutputIterator> template <class _InputIterator, class _OutputIterator>
inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 _OutputIterator copy(_InputIterator __first,
_OutputIterator _InputIterator __last,
copy(_InputIterator __first, _InputIterator __last, _OutputIterator __result) { _OutputIterator __result) {
return std::__copy(__first, __last, __result).second; return std::__copy(__first, __last, __result).second;
} }
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
#endif // _LIBCPP___ALGORITHM_COPY_H #endif // _LIBCPP___ALGORITHM_COPY_H