Page MenuHomePhabricator

[libc++abi] Reword uncaught exception termination message
ClosedPublic

Authored by ldionne on May 9 2022, 10:35 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGead7a5fc0436: [libc++abi] Reword uncaught exception termination message
Summary

When we terminate due to an exception being uncaught, libc++abi prints
a message saying "terminating with uncaught exception [...]". This patch
changes that to say "terminating due to uncaught exception [...]" instead,
which is a bit clearer. Indeed, I've seen some people being confused and
thinking that libc++abi was the component throwing the exception.

Diff Detail

Event Timeline

ldionne created this revision.May 9 2022, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2022, 10:35 AM
ldionne requested review of this revision.May 9 2022, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2022, 10:35 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 10 2022, 6:58 AM

CI failures are just flake, ignoring them.

This revision is now accepted and ready to land.May 10 2022, 6:58 AM
This revision was landed with ongoing or failed builds.May 10 2022, 6:59 AM
This revision was automatically updated to reflect the committed changes.