This is an archive of the discontinued LLVM Phabricator instance.

[debugserver] Fix sign comparison warning.
ClosedPublic

Authored by brucem on Aug 31 2015, 10:51 PM.

Details

Summary

Comparing m_page_size against kInvalidPageSize was resulting in
a warning about comparing integers with different signs. Since
kInvalidPageSize isn't used anywhere outside of MachVMMemory.cpp,
we can readily transform it into a static const vm_size_t with
the correct value to avoid the sign comparison warnings.

Diff Detail

Event Timeline

brucem updated this revision to Diff 33666.Aug 31 2015, 10:51 PM
brucem retitled this revision from to [debugserver] Fix sign comparison warning..
brucem updated this object.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
clayborg accepted this revision.Sep 1 2015, 9:49 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Sep 1 2015, 9:49 AM
This revision was automatically updated to reflect the committed changes.