This is an archive of the discontinued LLVM Phabricator instance.

Force the locale when executing ld gold
ClosedPublic

Authored by sylvestre.ledru on Aug 28 2015, 5:12 AM.

Reviewers

• rafael

Commits

Summary

If run with other locales (like French),
the decode operation might fail

sylvestre.ledru retitled this revision from to Force the locale when executing ld gold.

sylvestre.ledru updated this object.

Update another declaration

LGTM

This revision is now accepted and ready to land.Aug 28 2015, 5:23 AM

Path

Size

test/

2 lines

Show First 20 Lines • Show All 368 Lines • ▼ Show 20 Lines	def have_ld_plugin_support():
if len(fields) != 3:		if len(fields) != 3:
return False		return False
emulations = fields[2].split()		emulations = fields[2].split()
if 'elf_x86_64' not in emulations:		if 'elf_x86_64' not in emulations:
return False		return False
if 'elf32ppc' in emulations:		if 'elf32ppc' in emulations:
config.available_features.add('ld_emu_elf32ppc')		config.available_features.add('ld_emu_elf32ppc')

ld_version = subprocess.Popen([config.gold_executable, '--version'], stdout = subprocess.PIPE)		ld_version = subprocess.Popen([config.gold_executable, '--version'], stdout = subprocess.PIPE, env={'LANG': 'C'})
if not 'GNU gold' in ld_version.stdout.read().decode():		if not 'GNU gold' in ld_version.stdout.read().decode():
return False		return False
ld_version.wait()		ld_version.wait()

return True		return True

if have_ld_plugin_support():		if have_ld_plugin_support():
config.available_features.add('ld_plugin')		config.available_features.add('ld_plugin')
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines