Make SideEffectFinder publicly available (nfc)

[scott-0]

Summary

I'm going to use SideEffectFinder in my subsequent patch.

include/clang/AST/SideEffectFinder.h

+//===--- SideEffectFinder.h - Visitor for finding side-effects --*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+//  This file defines the SideEffectFinder.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_CLANG_AST_SIDEEFECTFINDER_H
+#define LLVM_CLANG_AST_SIDEEFECTFINDER_H
+
+#include "clang/AST/EvaluatedExprVisitor.h"
+
+namespace clang {
+/// \brief Look for any side effects within an Expr.
+class SideEffectFinder : public ConstEvaluatedExprVisitor<SideEffectFinder> {
+  typedef ConstEvaluatedExprVisitor<SideEffectFinder> Inherited;
+  const bool IncludePossibleEffects;
+  bool HasSideEffects;
+
+public:
+  explicit SideEffectFinder(const ASTContext &Context, bool IncludePossible)
+    : Inherited(Context),
+      IncludePossibleEffects(IncludePossible), HasSideEffects(false) { }
+
+  bool hasSideEffects() const { return HasSideEffects; }
+
+  void VisitExpr(const Expr *E) {
+    if (!HasSideEffects &&
+        E->HasSideEffects(Context, IncludePossibleEffects))
+      HasSideEffects = true;
+  }
+};
+}  // end namespace clang
+
+#endif

lib/AST/Expr.cpp

 #include "clang/AST/DeclCXX.h"
 #include "clang/AST/DeclObjC.h"
 #include "clang/AST/DeclTemplate.h"
 #include "clang/AST/EvaluatedExprVisitor.h"
 #include "clang/AST/Expr.h"
 #include "clang/AST/ExprCXX.h"
 #include "clang/AST/Mangle.h"
 #include "clang/AST/RecordLayout.h"
+#include "clang/AST/SideEffectFinder.h"
 #include "clang/AST/StmtVisitor.h"
 #include "clang/Basic/Builtins.h"
 #include "clang/Basic/CharInfo.h"
 #include "clang/Basic/SourceManager.h"
 #include "clang/Basic/TargetInfo.h"
 #include "clang/Lex/Lexer.h"
 #include "clang/Lex/LiteralSupport.h"
 #include "clang/Sema/SemaDiagnostic.h"
bool Expr::isConstantInitializer(ASTContext &Ctx, bool IsForRef,
   }
   if (isEvaluatable(Ctx))
     return true;
   if (Culprit)
     *Culprit = this;
   return false;
 }
 
-namespace {
-  /// \brief Look for any side effects within a Stmt.
-  class SideEffectFinder : public ConstEvaluatedExprVisitor<SideEffectFinder> {
-    typedef ConstEvaluatedExprVisitor<SideEffectFinder> Inherited;
-    const bool IncludePossibleEffects;
-    bool HasSideEffects;
-
-  public:
-    explicit SideEffectFinder(const ASTContext &Context, bool IncludePossible)
-      : Inherited(Context),
-        IncludePossibleEffects(IncludePossible), HasSideEffects(false) { }
-
-    bool hasSideEffects() const { return HasSideEffects; }
-
-    void VisitExpr(const Expr *E) {
-      if (!HasSideEffects &&
-          E->HasSideEffects(Context, IncludePossibleEffects))
-        HasSideEffects = true;
-    }
-  };
-}
-
 bool Expr::HasSideEffects(const ASTContext &Ctx,
                           bool IncludePossibleEffects) const {
   // In circumstances where we care about definite side effects instead of
   // potential side effects, we want to ignore expressions that are part of a
   // macro expansion as a potential side effect.
   if (!IncludePossibleEffects && getExprLoc().isMacroID())
     return false;