Page MenuHomePhabricator

Skip test which is causing ERRORs in dotest.py on OSX after r237053
ClosedPublic

Authored by dawn on Aug 25 2015, 12:20 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

dawn updated this revision to Diff 33101.Aug 25 2015, 12:20 PM
dawn retitled this revision from to Skip test which is causing ERRORs in dotest.py on OSX after r237053.
dawn updated this object.
dawn added reviewers: ted, clayborg.
dawn set the repository for this revision to rL LLVM.
dawn added a subscriber: lldb-commits.
clayborg requested changes to this revision.Aug 26 2015, 9:50 AM
clayborg edited edge metadata.

This test passes fine when running dosep.py so I would prefer to set this to expected failure

This revision now requires changes to proceed.Aug 26 2015, 9:50 AM
ted edited edge metadata.Aug 26 2015, 9:50 AM

The error also happens on Linux; this test should be turned off everywhere.

ted added a comment.Aug 26 2015, 9:56 AM

The problem with this test is it gets python in a bad state, so after it's run, all tests after error out. It runs fine on its own, but something like:
dotest.py python_api/

will give a lot of errors after this test runs.

dawn added a comment.Aug 26 2015, 10:20 AM

Greg, please reconsider. There are many options which dosep.py does not support, and the only way to get that functionality is by running dotest.py. There is no workaround. Thank you for understanding.

clayborg accepted this revision.Aug 26 2015, 10:51 AM
clayborg edited edge metadata.

Ah expected failing it won't help the tests pass. My bad. Check this in for now until we can fix it properly.

This revision is now accepted and ready to land.Aug 26 2015, 10:51 AM
dawn added a comment.Aug 26 2015, 11:04 AM

Thanks Greg!

test/python_api/disassemble-raw-data/TestDisassemble_VST1_64.py
15 ↗(On Diff #33101)

FYI - I will change this to:

@skipIf(True) # llvm.org/pr24575: all tests get ERRORs in dotest.py after this

as per Ted's recommendation.

This revision was automatically updated to reflect the committed changes.