Page MenuHomePhabricator

Handle DW_OP_GNU_addr_index in DWARF expressions
ClosedPublic

Authored by tberghammer on Aug 24 2015, 10:04 AM.

Details

Summary

Handle DW_OP_GNU_addr_index in DWARF expressions

This is a new operand in the dwarf expressions used when split dwarf is enabled

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Handle DW_OP_GNU_addr_index in DWARF expressions.
tberghammer updated this object.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
clayborg accepted this revision.Aug 24 2015, 10:54 AM
clayborg edited edge metadata.

Looks good.

DWARFExpression is unique in that it is separate from the DWARF plug-in itself because DWARF expressions are in .eh_frame and other things that don't require the rest of DWARF. It would be nice to not pass a DWARFCompileUnit to DWARFExpression, but then we would need to abstract everything we needed from DWARFCompileUnit into lldb_private::CompileUnit and the things we get from the DWARFCompileUnit are not things we want in the lldb_private::CompileUnit API, so this is the right solution.

This revision is now accepted and ready to land.Aug 24 2015, 10:54 AM
This revision was automatically updated to reflect the committed changes.