This is an archive of the discontinued LLVM Phabricator instance.

Differential D12203

Fix some format strings in ProcessGDBRemote.cpp.
ClosedPublic

Authored by sas on Aug 20 2015, 11:49 AM.

Details

Reviewers
clayborg
ADodds
Commits
rG03fc3f765771: Fix some format strings in ProcessGDBRemote.cpp.
rLLDB245608: Fix some format strings in ProcessGDBRemote.cpp.
rL245608: Fix some format strings in ProcessGDBRemote.cpp.
Summary

Size specifier should come after % not before.

Diff Detail

Event Timeline

sas updated this revision to Diff 32719.Aug 20 2015, 11:49 AM
sas retitled this revision from to Fix some format strings in ProcessGDBRemote.cpp..
sas updated this object.
sas added reviewers: clayborg, ADodds.
sas added a subscriber: lldb-commits.
clayborg accepted this revision.Aug 20 2015, 12:45 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Aug 20 2015, 12:45 PM
Closed by commit rL245608: Fix some format strings in ProcessGDBRemote.cpp. (authored by sas). · Explain WhyAug 20 2015, 1:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
source/
Plugins/
Process/
gdb-remote/
4 lines

Diff 32719

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Show First 20 Lines • Show All 4,597 Lines • ▼ Show 20 Lines if (comm.GetQXferLibrariesSVR4ReadSupported ()) {
std::string name; std::string name;
lldb::addr_t lm=0, base=0, ld=0; lldb::addr_t lm=0, base=0, ld=0;
module.get_name (name); module.get_name (name);
module.get_link_map (lm); module.get_link_map (lm);
module.get_base (base); module.get_base (base);
module.get_dynamic (ld); module.get_dynamic (ld);
log->Printf ("found (link_map:0x08%" PRIx64 ", base:0x08%" PRIx64 ", ld:0x08%" PRIx64 ", name:'%s')", lm, base, ld, name.c_str()); log->Printf ("found (link_map:0x%08" PRIx64 ", base:0x%08" PRIx64 ", ld:0x%08" PRIx64 ", name:'%s')", lm, base, ld, name.c_str());
} }
list.add (module); list.add (module);
return true; // Keep iterating over all "library" elements in the root node return true; // Keep iterating over all "library" elements in the root node
}); });
if (log) if (log)
log->Printf ("found %" PRId32 " modules in total", (int) list.m_list.size()); log->Printf ("found %" PRId32 " modules in total", (int) list.m_list.size());
Show All 33 Lines if (comm.GetQXferLibrariesSVR4ReadSupported ()) {
if (log) if (log)
{ {
std::string name; std::string name;
lldb::addr_t base = 0; lldb::addr_t base = 0;
module.get_name (name); module.get_name (name);
module.get_base (base); module.get_base (base);
log->Printf ("found (base:0x%" PRIx64 ", name:'%s')", base, name.c_str()); log->Printf ("found (base:0x%08" PRIx64 ", name:'%s')", base, name.c_str());
} }
list.add (module); list.add (module);
return true; // Keep iterating over all "library" elements in the root node return true; // Keep iterating over all "library" elements in the root node
}); });
if (log) if (log)
log->Printf ("found %" PRId32 " modules in total", (int) list.m_list.size()); log->Printf ("found %" PRId32 " modules in total", (int) list.m_list.size());
▲ Show 20 Lines • Show All 466 Lines • Show Last 20 Lines