This is an archive of the discontinued LLVM Phabricator instance.

Fix some MicroBenchmark failed at profile generation run
AbandonedPublic

Authored by taolq on Feb 23 2022, 5:50 AM.

Details

Reviewers
MatzeB
Summary

When -DTEST_SUITE_PROFILE_GENERATE=ON is set, some MicroBenchmark failed
because of the combination of env and cd command, shown at test.log

env LLVM_PROFILE_FILE=/home/taoliq/test-suite-build/O3-MicroBench/LoopInterchange/Output/LoopInterchange.test.profraw cd /home/taoliq/test-suite-build/O3-MicroBench/LoopInterchange && /home/taoliq/test-suite-build/O3-MicroBench/LoopInterchange/LoopInterchange --benchmark_format=json > /home/taoliq/test-suite-build/O3-MicroBench/LoopInterchange/Output/LoopInterchange.test.bench.json

env: 'cd': No such file or directory

Reproduce step

1. cmake -DCMAKE_C_COMPILER=$HOME/llvm-project/build/bin/clang -DTEST_SUITE_PROFILE_GENERATE=ON \
-DTEST_SUITE_RUN_TYPE=train -C../test-suite/cmake/caches/O3.cmake \
../test-suite

2. make -j32

3. llvm-lit MicroBenchmarks

The result

********************
Failed Tests (8):
  test-suite :: MicroBenchmarks/ImageProcessing/AnisotropicDiffusion/AnisotropicDiffusion.test
  test-suite :: MicroBenchmarks/ImageProcessing/BilateralFiltering/BilateralFilter.test
  test-suite :: MicroBenchmarks/ImageProcessing/Blur/blur.test
  test-suite :: MicroBenchmarks/ImageProcessing/Dilate/Dilate.test
  test-suite :: MicroBenchmarks/ImageProcessing/Dither/Dither.test
  test-suite :: MicroBenchmarks/ImageProcessing/Interpolation/Interpolation.test
  test-suite :: MicroBenchmarks/LoopInterchange/LoopInterchange.test
  test-suite :: MicroBenchmarks/harris/harris.test


Testing Time: 154.29s
  Passed: 12
  Failed:  8

Event Timeline

taolq requested review of this revision.Feb 23 2022, 5:50 AM
taolq created this revision.
taolq updated this revision to Diff 410799.Feb 23 2022, 6:16 AM

update patch with arc

Thanks for the report and fix, could you test if this works for you too, and accept if so: D121225 ? Using shellcommand centralizes some of the tricky bits of understanding and modifying shell command lines...

Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 9:09 AM
taolq abandoned this revision.Mar 9 2022, 4:50 PM