Page MenuHomePhabricator
People taolq

taolq (Liqiang Tao)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 17 2021, 6:58 PM (109 w, 1 d)

Recent Activity
View All

Sep 29 2022

taolq accepted D134376: [ModuleInliner] Add a cost-benefit-based priority.

LGTM.
Thanks for this work. It's glad to see this infrastructure works well.
Looking forward to discovering reasonable heuristics :-D
Don't forget to resolve the comment.

Sep 29 2022, 12:59 AM · Restricted Project, Restricted Project

Sep 21 2022

taolq accepted D134149: [ModuleInliner] Factor out common code in InlineOrder.cpp (NFC).

LGTM.
Thanks for the job.

Sep 21 2022, 8:27 AM · Restricted Project, Restricted Project

Sep 18 2022

taolq added a comment to D133860: StackProtector: enable tail call optimization even without musttail.
In D133860#3796726, @efriedma wrote:

Do we care that the backend might not choose to tail-call a function even if it's in tail position? The "tail" marker is a hint; depending on attributes, calling convention, etc., the backend might not actually generate a tail call.

Sep 18 2022, 4:42 PM · Restricted Project, Restricted Project

Sep 17 2022

taolq accepted D134114: [Analysis] Introduce isSoleCallToLocalFunction (NFC).

LGTM

Sep 17 2022, 7:15 PM · Restricted Project, Restricted Project
taolq accepted D134100: [ModuleInliner] Move UseInlinePriority to InlineOrder.cpp (NFC).

LGTM

Sep 17 2022, 6:49 AM · Restricted Project, Restricted Project

Sep 16 2022

taolq accepted D133969: [IPO] Simplify the module inliner loop (NFC).

LGTM :)

Sep 16 2022, 7:32 AM · Restricted Project, Restricted Project
taolq committed rG2e37557fdeed: StackProtector: ensure stack checks are inserted before the tail call (authored by taolq).
StackProtector: ensure stack checks are inserted before the tail call
Sep 16 2022, 7:25 AM · Restricted Project, Restricted Project
taolq closed D133860: StackProtector: enable tail call optimization even without musttail.
Sep 16 2022, 7:25 AM · Restricted Project, Restricted Project
taolq updated the diff for D133860: StackProtector: enable tail call optimization even without musttail.
  • fix format
Sep 16 2022, 7:02 AM · Restricted Project, Restricted Project
taolq updated the diff for D133860: StackProtector: enable tail call optimization even without musttail.
  • update the comment
  • add missing newline
Sep 16 2022, 6:58 AM · Restricted Project, Restricted Project

Sep 15 2022

taolq added a comment to D133860: StackProtector: enable tail call optimization even without musttail.
In D133860#3790200, @compnerd wrote:

What do you think of keeping the musttail variant of the test while augmenting it with the tailcall cases?

Sep 15 2022, 7:35 AM · Restricted Project, Restricted Project
taolq updated the diff for D133860: StackProtector: enable tail call optimization even without musttail.
  • append tail cases to musttail test
Sep 15 2022, 7:34 AM · Restricted Project, Restricted Project

Sep 14 2022

taolq retitled D133860: StackProtector: enable tail call optimization even without musttail from ensure protection does not disable tail call opt to StackProtector: enable tail call optimization even without musttail.
Sep 14 2022, 7:37 AM · Restricted Project, Restricted Project
taolq requested review of D133860: StackProtector: enable tail call optimization even without musttail.
Sep 14 2022, 7:18 AM · Restricted Project, Restricted Project

Jul 28 2022

taolq committed rGd52e775b05a4: [llvm][ModuleInliner] Add inline cost priority for module inliner (authored by taolq).
[llvm][ModuleInliner] Add inline cost priority for module inliner
Jul 28 2022, 7:45 AM · Restricted Project, Restricted Project
taolq added a reverting change for rGbb7f62bbbd35: [llvm][ModuleInliner] Add inline cost priority for module inliner: rGc113594378a0: Revert "[llvm][ModuleInliner] Add inline cost priority for module inliner".
Jul 28 2022, 7:37 AM · Restricted Project, Restricted Project
taolq committed rGc113594378a0: Revert "[llvm][ModuleInliner] Add inline cost priority for module inliner" (authored by taolq).
Revert "[llvm][ModuleInliner] Add inline cost priority for module inliner"
Jul 28 2022, 7:37 AM · Restricted Project, Restricted Project
taolq added a reverting change for D130012: [llvm][ModuleInliner] Add inline cost priority for module inliner: rGc113594378a0: Revert "[llvm][ModuleInliner] Add inline cost priority for module inliner".
Jul 28 2022, 7:37 AM · Restricted Project, Restricted Project
taolq committed rGbb7f62bbbd35: [llvm][ModuleInliner] Add inline cost priority for module inliner (authored by taolq).
[llvm][ModuleInliner] Add inline cost priority for module inliner
Jul 28 2022, 6:29 AM · Restricted Project, Restricted Project
taolq closed D130012: [llvm][ModuleInliner] Add inline cost priority for module inliner.
Jul 28 2022, 6:29 AM · Restricted Project, Restricted Project

Jul 27 2022

taolq updated the diff for D130012: [llvm][ModuleInliner] Add inline cost priority for module inliner.
  • rebase to main
  • resolve reviews
Jul 27 2022, 8:09 AM · Restricted Project, Restricted Project

Jul 18 2022

taolq retitled D130012: [llvm][ModuleInliner] Add inline cost priority for module inliner from Add inline cost priority for module inliner to [llvm][ModuleInliner] Add inline cost priority for module inliner.
Jul 18 2022, 7:54 AM · Restricted Project, Restricted Project
taolq requested review of D130012: [llvm][ModuleInliner] Add inline cost priority for module inliner.
Jul 18 2022, 7:50 AM · Restricted Project, Restricted Project

Jun 2 2022

taolq committed rG14e8add93977: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder (authored by taolq).
[llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder
Jun 2 2022, 8:41 AM · Restricted Project, Restricted Project
taolq added a reverting change for rG50de7f1e7787: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder: rG5c6ed60c517c: Revert "[llvm][ModuleInliner] Refactor InlineSizePriority and….
Jun 2 2022, 8:19 AM · Restricted Project, Restricted Project
taolq committed rG5c6ed60c517c: Revert "[llvm][ModuleInliner] Refactor InlineSizePriority and… (authored by taolq).
Revert "[llvm][ModuleInliner] Refactor InlineSizePriority and…
Jun 2 2022, 8:19 AM · Restricted Project, Restricted Project
taolq added a reverting change for D126300: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder: rG5c6ed60c517c: Revert "[llvm][ModuleInliner] Refactor InlineSizePriority and….
Jun 2 2022, 8:19 AM · Restricted Project, Restricted Project
taolq committed rG50de7f1e7787: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder (authored by taolq).
[llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder
Jun 2 2022, 7:29 AM · Restricted Project, Restricted Project
taolq closed D126300: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder.
Jun 2 2022, 7:29 AM · Restricted Project, Restricted Project
taolq updated the diff for D126300: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder.
  • rebase to main
Jun 2 2022, 5:24 AM · Restricted Project, Restricted Project

May 29 2022

taolq updated the diff for D126300: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder.
  • rename compare to hasLowerPriority
May 29 2022, 6:28 AM · Restricted Project, Restricted Project

May 26 2022

taolq retitled D126300: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder from [llvm][Inline] Refactor InlinePriority to [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder.
May 26 2022, 9:06 AM · Restricted Project, Restricted Project
taolq updated the diff for D126300: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder.
  • use iterator to decrease rehashing
May 26 2022, 9:04 AM · Restricted Project, Restricted Project

May 24 2022

taolq retitled D126300: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder from refactor InlinePriority to [llvm][Inline] Refactor InlinePriority.
May 24 2022, 7:17 AM · Restricted Project, Restricted Project
taolq requested review of D126300: [llvm][ModuleInliner] Refactor InlineSizePriority and PriorityInlineOrder.
May 24 2022, 7:15 AM · Restricted Project, Restricted Project

Apr 26 2022

taolq committed rGb9fc18f89acc: [llvm][Inline] Remove PriorityInlineOrder in SCC inliner (authored by taolq).
[llvm][Inline] Remove PriorityInlineOrder in SCC inliner
Apr 26 2022, 5:21 AM · Restricted Project, Restricted Project
taolq closed D123608: [llvm][Inline] Remove PriorityInlineOrder in SCC inliner.
Apr 26 2022, 5:20 AM · Restricted Project, Restricted Project

Apr 20 2022

taolq updated the diff for D123608: [llvm][Inline] Remove PriorityInlineOrder in SCC inliner.
  • replace Calls uniptr with instance
  • Fix missing option in tests
Apr 20 2022, 5:15 AM · Restricted Project, Restricted Project

Apr 19 2022

taolq updated the diff for D123608: [llvm][Inline] Remove PriorityInlineOrder in SCC inliner.
  • replace Calls uniptr with instance
Apr 19 2022, 8:18 AM · Restricted Project, Restricted Project

Apr 12 2022

taolq retitled D123608: [llvm][Inline] Remove PriorityInlineOrder in SCC inliner from Remove PriorityOrder in SCC inliner to [llvm][Inline] Remove PriorityInlineOrder in SCC inliner.
Apr 12 2022, 7:12 AM · Restricted Project, Restricted Project
taolq requested review of D123608: [llvm][Inline] Remove PriorityInlineOrder in SCC inliner.
Apr 12 2022, 7:01 AM · Restricted Project, Restricted Project

Mar 9 2022

taolq abandoned D120406: Fix some MicroBenchmark failed at profile generation run.
Mar 9 2022, 4:50 PM · Restricted Project
taolq accepted D121225: Use litsupport.shellcommand to set LLVM_PROFILE_FILE.

Thanks for the fix.
This patch works well. All MicroBenchmarks passed at the profile generation run.

Mar 9 2022, 6:41 AM · Restricted Project

Feb 23 2022

taolq updated the diff for D120406: Fix some MicroBenchmark failed at profile generation run.

update patch with arc

Feb 23 2022, 6:16 AM · Restricted Project
taolq abandoned D120409: fix failed micro bench.
Feb 23 2022, 6:15 AM
taolq requested review of D120409: fix failed micro bench.
Feb 23 2022, 6:14 AM
taolq requested review of D120406: Fix some MicroBenchmark failed at profile generation run.
Feb 23 2022, 5:50 AM · Restricted Project

Dec 2 2021

taolq committed rG7e8f9d6b38a4: [llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline (authored by taolq).
[llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline
Dec 2 2021, 7:15 PM
taolq closed D114704: [llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline.
Dec 2 2021, 7:15 PM · Restricted Project

Nov 30 2021

taolq added a comment to D114704: [llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline.
In D114704#3159012, @lebedev.ri wrote:

Tests?
Presumably this is default-off?

Nov 30 2021, 6:40 AM · Restricted Project
taolq updated the diff for D114704: [llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline.
  • address clang-format
Nov 30 2021, 6:29 AM · Restricted Project

Nov 29 2021

taolq updated the summary of D114704: [llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline.
Nov 29 2021, 6:06 AM · Restricted Project
taolq updated the diff for D114704: [llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline.
  • add necessary file
Nov 29 2021, 6:03 AM · Restricted Project
taolq retitled D114704: [llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline from add FunctionSimplificationPipeline to module inliner pipeline to [llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline.
Nov 29 2021, 6:01 AM · Restricted Project
taolq requested review of D114704: [llvm][Inline] Add FunctionSimplificationPipeline to module inliner pipeline.
Nov 29 2021, 5:58 AM · Restricted Project

Nov 8 2021

taolq committed rG6cad45d5c6f5: [llvm][Inline] Add a module level inliner (authored by taolq).
[llvm][Inline] Add a module level inliner
Nov 8 2021, 7:07 PM
taolq closed D106448: [llvm][Inline] Add a module level inliner.
Nov 8 2021, 7:06 PM · Restricted Project
taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • remove inliner replay logic
Nov 8 2021, 2:09 AM · Restricted Project

Oct 29 2021

taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • clean code
Oct 29 2021, 8:34 AM · Restricted Project
taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • clean code
  • rebase to main branch
Oct 29 2021, 8:31 AM · Restricted Project

Oct 22 2021

taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • remove comment in code
Oct 22 2021, 7:57 AM · Restricted Project
taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • remove comment in code
Oct 22 2021, 7:54 AM · Restricted Project
taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • refactor to avoid touching the existing inliner
Oct 22 2021, 7:50 AM · Restricted Project
taolq added inline comments to D106448: [llvm][Inline] Add a module level inliner.
Oct 22 2021, 5:36 AM · Restricted Project

Oct 19 2021

taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • fix bug
Oct 19 2021, 6:01 AM · Restricted Project

Oct 18 2021

taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • rebase to the newest main branch
Oct 18 2021, 7:24 AM · Restricted Project

Sep 10 2021

taolq added a comment to D106448: [llvm][Inline] Add a module level inliner.
In D106448#2970314, @taolq wrote:
In D106448#2941757, @lebedev.ri wrote:

The error is likely on my side, but i'm still not quite seeing it.
I don't see the point in asking yet again, so i would like to instead see an RFC at llvm-dev list.

FYI, let me put the RFC here, https://lists.llvm.org/pipermail/llvm-dev/2021-August/152297.html
How about this one? Looking forward to your comments.

Sep 10 2021, 2:53 AM · Restricted Project

Aug 27 2021

taolq added a comment to D106448: [llvm][Inline] Add a module level inliner.
In D106448#2941757, @lebedev.ri wrote:

The error is likely on my side, but i'm still not quite seeing it.
I don't see the point in asking yet again, so i would like to instead see an RFC at llvm-dev list.

Aug 27 2021, 5:40 PM · Restricted Project
taolq updated the summary of D106448: [llvm][Inline] Add a module level inliner.
Aug 27 2021, 5:27 PM · Restricted Project

Aug 12 2021

taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • remove duplicate code: InlineOrder
Aug 12 2021, 8:46 AM · Restricted Project
taolq committed rG422fc5603ab5: [llvm][Inline] Refactor out InlineOrder (authored by taolq).
[llvm][Inline] Refactor out InlineOrder
Aug 12 2021, 7:22 AM
taolq closed D107831: [llvm][Inline] Refactor out InlineOrder.
Aug 12 2021, 7:21 AM · Restricted Project

Aug 11 2021

taolq updated the diff for D107831: [llvm][Inline] Refactor out InlineOrder.
  • fix clang-tidy errors
Aug 11 2021, 7:23 AM · Restricted Project

Aug 10 2021

taolq retitled D107831: [llvm][Inline] Refactor out InlineOrder from Refactor out InlineOrder to [llvm][Inline] Refactor out InlineOrder.
Aug 10 2021, 8:18 AM · Restricted Project
taolq requested review of D107831: [llvm][Inline] Refactor out InlineOrder.
Aug 10 2021, 8:16 AM · Restricted Project

Aug 9 2021

taolq added a comment to D106448: [llvm][Inline] Add a module level inliner.
In D106448#2934696, @lebedev.ri wrote:
In D106448#2934674, @taolq wrote:
  • fix bugs
  • add more description

I think my question is: why is the code worth it? what's the short-term plan? what's the long-term plan?
Having *so* much intentional code duplication seems counter-intuitive.

Aug 9 2021, 8:45 AM · Restricted Project
taolq updated the summary of D106448: [llvm][Inline] Add a module level inliner.
Aug 9 2021, 8:39 AM · Restricted Project
taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • fix bugs
  • add more description
Aug 9 2021, 8:34 AM · Restricted Project
taolq retitled D106448: [llvm][Inline] Add a module level inliner from [WIP] [llvm][Inline] Add module level inliner to [llvm][Inline] Add a module level inliner.
Aug 9 2021, 8:33 AM · Restricted Project

Aug 2 2021

taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • add module inliner to opt pipeline
  • TODO: remove duplicated code
  • TODO: add more description
Aug 2 2021, 8:12 AM · Restricted Project

Jul 25 2021

taolq committed rG4bdfea2c5152: [llvm][Inline] Add interface to return cost-benefit stuff (authored by taolq).
[llvm][Inline] Add interface to return cost-benefit stuff
Jul 25 2021, 5:45 AM
taolq closed D105349: [llvm][Inline] Add interface to return cost-benefit stuff.
Jul 25 2021, 5:45 AM · Restricted Project

Jul 24 2021

taolq updated the diff for D106448: [llvm][Inline] Add a module level inliner.
  • move code to a separated file
Jul 24 2021, 2:10 AM · Restricted Project

Jul 21 2021

taolq retitled D106448: [llvm][Inline] Add a module level inliner from add module inliner to [WIP] [llvm][Inline] Add module level inliner.
Jul 21 2021, 8:03 AM · Restricted Project
taolq requested review of D106448: [llvm][Inline] Add a module level inliner.
Jul 21 2021, 7:54 AM · Restricted Project

Jul 11 2021

taolq committed rG6ebeb7f8baf3: [llvm][Inliner] Templatize PriorityInlineOrder (authored by taolq).
[llvm][Inliner] Templatize PriorityInlineOrder
Jul 11 2021, 7:39 PM
taolq closed D104972: [llvm][Inliner] Templatize PriorityInlineOrder.
Jul 11 2021, 7:39 PM · Restricted Project

Jul 9 2021

taolq updated the diff for D105349: [llvm][Inline] Add interface to return cost-benefit stuff.
  • return const APInt&
Jul 9 2021, 11:53 PM · Restricted Project
taolq updated the diff for D105349: [llvm][Inline] Add interface to return cost-benefit stuff.
  • use const accessors to keep readability and maintainability
Jul 9 2021, 9:33 AM · Restricted Project

Jul 8 2021

taolq added inline comments to D105349: [llvm][Inline] Add interface to return cost-benefit stuff.
Jul 8 2021, 5:02 PM · Restricted Project
taolq abandoned D105198: [WIP][llvm][Inline] Add helper function for inliner.
Jul 8 2021, 8:50 AM · Restricted Project
taolq updated the diff for D105349: [llvm][Inline] Add interface to return cost-benefit stuff.
  • add struct to represent cost-benefit pair
  • remove redundant interface to return cost-benefit pair
Jul 8 2021, 8:49 AM · Restricted Project

Jul 2 2021

taolq updated the summary of D105349: [llvm][Inline] Add interface to return cost-benefit stuff.
Jul 2 2021, 7:46 AM · Restricted Project
taolq requested review of D105349: [llvm][Inline] Add interface to return cost-benefit stuff.
Jul 2 2021, 7:43 AM · Restricted Project

Jul 1 2021

taolq updated the diff for D104972: [llvm][Inliner] Templatize PriorityInlineOrder.
  • renaming size -> Size
Jul 1 2021, 6:36 PM · Restricted Project
taolq updated the diff for D104972: [llvm][Inliner] Templatize PriorityInlineOrder.
  • renaming
Jul 1 2021, 2:27 AM · Restricted Project
taolq updated the diff for D104972: [llvm][Inliner] Templatize PriorityInlineOrder.
  • pack one class Priority
Jul 1 2021, 2:24 AM · Restricted Project
taolq updated the diff for D104972: [llvm][Inliner] Templatize PriorityInlineOrder.
Jul 1 2021, 2:23 AM · Restricted Project

Jun 30 2021

taolq updated the summary of D105198: [WIP][llvm][Inline] Add helper function for inliner.
Jun 30 2021, 8:12 AM · Restricted Project
taolq requested review of D105198: [WIP][llvm][Inline] Add helper function for inliner.
Jun 30 2021, 8:08 AM · Restricted Project