This is an archive of the discontinued LLVM Phabricator instance.

[ARMv8] New NEON instructions VCVT{A, N, P, M}
ClosedPublic

Authored by joey on Jul 17 2013, 8:04 AM.

Details

Reviewers
t.p.northover
Summary

As title says.

Diff Detail

Event Timeline

Couple of things:

  1. There's no requirements at all on these; they want v8 and NEON to be enabled.
  2. The instructions are going to be called things like "VCVTAnSD". What does that "n" mean?
joey added a comment.Jul 17 2013, 9:05 AM
  1. There's no requirements at all on these; they want v8 and NEON to be enabled.

Sorry, silly mistake again.

  1. The instructions are going to be called things like "VCVTAnSD". What does that "n" mean?

The "n" stands for NEON, since I already have a VCVTA that it would clash with. I should change it to "N" since that's the suffix I used for vmaxnm/vminnm. Or did you miss it on the previous review, and I should be doing something different?

t.p.northover accepted this revision.Jul 17 2013, 9:14 AM

Oh no, that 'n' makes sense now. I'm happy wirh that explanation. Go ahead once you've added the Requires flags.

joey added a comment.Jul 18 2013, 4:55 AM

Thanks again Tim!

r186574.

joey closed this revision.Jul 18 2013, 4:55 AM