This is an archive of the discontinued LLVM Phabricator instance.

Differential D115475

[ASan] Fix Windows build by excluding a test which requires assembly callback versions.
ClosedPublic

Authored by kstoimenov on Dec 9 2021, 3:39 PM.

Details

Reviewers
kstoimenov
Commits
rGd3ca749288c9: [ASan] Fix Windows build by excluding a test which requires assembly callback…

Diff Detail

Event Timeline

kstoimenov requested review of this revision.Dec 9 2021, 3:39 PM
kstoimenov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2021, 3:39 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov accepted this revision.Dec 9 2021, 3:40 PM
This revision is now accepted and ready to land.Dec 9 2021, 3:40 PM
This revision was landed with ongoing or failed builds.Dec 9 2021, 3:41 PM
Closed by commit rGd3ca749288c9: [ASan] Fix Windows build by excluding a test which requires assembly callback… (authored by kstoimenov). · Explain Why
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rGd3ca749288c9: [ASan] Fix Windows build by excluding a test which requires assembly callback….
Harbormaster completed remote builds in B138543: Diff 393306.Dec 9 2021, 3:56 PM

Revision Contents

PathSize
compiler-rt/
lib/
asan/
tests/
7 lines

Diff 393307

compiler-rt/lib/asan/tests/asan_noinst_test.cpp

Show First 20 Lines • Show All 275 Lines • ▼ Show 20 Lines CB cb[2][5] = {{
__asan_store2, __asan_store2,
__asan_store4, __asan_store4,
__asan_store8, __asan_store8,
__asan_store16, __asan_store16,
}}; }};
TestLoadStoreCallbacks(cb); TestLoadStoreCallbacks(cb);
} }
// clang-format off #if defined(__x86_64__) && \
#if defined(__x86_64__) !(defined(SANITIZER_MAC) || defined(SANITIZER_WINDOWS))
// clang-format off
#define CALL_ASAN_MEMORY_ACCESS_CALLBACK_ADD(s, reg, op) \ #define CALL_ASAN_MEMORY_ACCESS_CALLBACK_ADD(s, reg, op) \
void CallAsanMemoryAccessAdd##reg##op##s(uptr address) { \ void CallAsanMemoryAccessAdd##reg##op##s(uptr address) { \
asm("push %%" #reg " \n" \ asm("push %%" #reg " \n" \
"mov %[x], %%" #reg " \n" \ "mov %[x], %%" #reg " \n" \
"call __asan_check_" #op "_add_" #s "_" #reg "\n" \ "call __asan_check_" #op "_add_" #s "_" #reg "\n" \
"pop %%" #reg " \n" \ "pop %%" #reg " \n" \
: \ : \
: [x] "r"(address) \ : [x] "r"(address) \
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RDI) TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RDI)
TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RBP) TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RBP)
TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R8) TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R8)
TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R9) TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R9)
TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R12) TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R12)
TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R13) TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R13)
TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R14) TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R14)
TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R15) TEST_ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R15)
// clang-format on
#endif // defined(__x86_64__) #endif // defined(__x86_64__)
// clang-format on