[test-suite] Fix signed integer overflow error for pc1cod.c

[Shrill]

Summary

The patch fixes a test fail when compiling the benchmark using GCC 9.3.0. The benchmark was failing because of a signed integer overflow runtime error in the pc1code.c. This caused the file to have undefined behaviour and the output generated didn't pass the verification test.

The patch induces the modification of the data type of the variables causing the signed integer overflow to prevent the error.

Co-Author: @adata111

[MatzeB]

Does the benchmark still produces the same values when going from int to unsigned? No change to *.reference_output necessary?

[adata111]

In D113639#3124747, @MatzeB wrote:

Does the benchmark still produces the same values when going from int to unsigned? No change to *.reference_output necessary?

No, no change to *.reference_output is necessary, the *.reference_output produced after changing to unsigned is the same as the previous one
The benchmark was failing for the GCC compiler and this change just fixes that.

[MatzeB]

LGTM! I'll land it.

[MatzeB]

It seems something is off with the line endings of the patch (or arc patch D113639 is failing on my end). The changed lines get a CR+LF instead of a unix LF line ending. How did you produce and upload the patch?

[Shrill]

In D113639#3125594, @MatzeB wrote:

It seems something is off with the line endings of the patch (or arc patch D113639 is failing on my end). The changed lines get a CR+LF instead of a unix LF line ending. How did you produce and upload the patch?

I generated a patch file using: git show HEAD -U999999 > mypatch.patch as mentioned in the code review webpage and uploaded the file using differential.

I wasn't aware it generated the patch file with CR+LF line ending. I will change the line endings to LF and upload the updated patch file.

[Shrill]

Change line endings from CR+LF to LF.

[MatzeB]

Just double checked and it seems you got it "right" the first time. Turns out the source file for this benchmark has CR+LF line endings, so your patch having them was correct. (My git pager view or the git diff output somehow produce odd output marking the changed lines with different line endings, but this was on my end).

I committed the change now.

MultiSource/Benchmarks/Trimaran/enc-pc1/pc1cod.c

code()
   
   i = i + 1;
   
   return (0);
   
 } 
 
 /* Use Linear congruential PRNG */
-int my_rand_r(int *seedp)
+unsigned my_rand_r(unsigned *seedp)
 {
   /* Knuth & Lewis */
   unsigned x = *seedp * 1664525 + 1013904223;
   *seedp = x;
   return (x >> 16) & 0x7fff;
 }
 
 main(int argc, const char **argv) 
 {
   int NumInput = 20000;
   int Print;
-  int random_seed = 1;
+  unsigned random_seed = 1;
   
   if (argc == 2) NumInput = atoi(argv[1]);
   
   si = 0;
   
   x1a2 = 0;
   
   i = 0;