This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add missing annotations for TEST_HAS_NO_WIDE_CHARACTERS
ClosedPublic

Authored by ldionne on Nov 1 2021, 9:12 AM.

Details

Summary

Those tests would pass when run on a C Standard Library that actually
provides wide characters, but fail when run on top of one that doesn't.
It's really difficult to test this 100% perfectly in the CI without
introducing an actual platform that doesn't provide these declarations.

Diff Detail

Event Timeline

ldionne requested review of this revision.Nov 1 2021, 9:12 AM
ldionne created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2021, 9:12 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Nov 1 2021, 11:10 AM
This revision is now accepted and ready to land.Nov 1 2021, 11:10 AM