Expr evaluation - Avoid to check when the memory handle is zero

[dean]

Summary

This change avoids to check whether the handle returned for an allocation of memory in IRForTarget::CompleteDataAllocation is zero, which is apparently a valid handle. The method IRForTarget::StaticDataAllocator::Allocate() returns LLDB_INVALID_ADDRESS in case of error, whereas, when the policy is eAllocationPolicyHostOnly, the first allocation performed by IRMemoryMap::Malloc and FindSpace is the value 0 for the first allocation.

This fix should restore the fall-back mode to evaluate expressions through local interpretation when an allocation by IRForTarget::CompleteDataAllocation is performed.

[dean]

Hi, as friendly *bump*, can you please provide any feedback regarding this patch? Let me know whether further details or info are required...

[spyffe]

This code has been eliminated as -part of a refactoring of the way IRForTarget works.
I'm sorry that I didn't get to this review earlier, but at this point the patch probably isn't worth resurrecting.
I've hunted around for "equivalent" code after the refactor and I don't think it's there any more.

source/Expression/IRForTarget.cpp

 
     if (log)
     {
-        if (allocation)
+        if (allocation != LLDB_INVALID_ADDRESS)
             log->Printf("Allocated static data at 0x%llx", (unsigned long long)allocation);
         else
             log->Printf("Failed to allocate static data");
     }
 
-    if (!allocation || allocation == LLDB_INVALID_ADDRESS)
+    if (allocation == LLDB_INVALID_ADDRESS)
         return false;
 
     Constant *relocated_addr = ConstantInt::get(m_intptr_ty, (uint64_t)allocation);