This is an archive of the discontinued LLVM Phabricator instance.

Differential D110866

[libc++abi] Mark __cxa_new_handler with _LIBCPP_SAFE_STATIC
ClosedPublic

Authored by ldionne on Sep 30 2021, 11:18 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGd9346f525595: [libc++abi] Mark __cxa_new_handler with _LIBCPP_SAFE_STATIC
Summary

For consistency with the other handlers, and because requiring constant
initialization whenever we can is a good thing.

Diff Detail

Event Timeline

ldionne requested review of this revision.Sep 30 2021, 11:18 AM
ldionne created this revision.
Harbormaster completed remote builds in B126609: Diff 376296.Sep 30 2021, 11:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2021, 11:18 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne updated this revision to Diff 377042.Oct 4 2021, 3:35 PM

Poke CI

Harbormaster completed remote builds in B126934: Diff 377042.Oct 4 2021, 5:57 PM
ldionne accepted this revision.Oct 5 2021, 11:28 AM
This revision is now accepted and ready to land.Oct 5 2021, 11:28 AM
Closed by commit rGd9346f525595: [libc++abi] Mark __cxa_new_handler with _LIBCPP_SAFE_STATIC (authored by ldionne). · Explain WhyOct 5 2021, 11:29 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGd9346f525595: [libc++abi] Mark __cxa_new_handler with _LIBCPP_SAFE_STATIC.

Revision Contents

PathSize
libcxxabi/
src/
3 lines

Diff 377315

libcxxabi/src/cxa_default_handlers.cpp

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Lines
// Global variables that hold the pointers to the current handler // Global variables that hold the pointers to the current handler
// //
_LIBCXXABI_DATA_VIS _LIBCXXABI_DATA_VIS
_LIBCPP_SAFE_STATIC std::terminate_handler __cxa_terminate_handler = default_terminate_handler; _LIBCPP_SAFE_STATIC std::terminate_handler __cxa_terminate_handler = default_terminate_handler;
_LIBCXXABI_DATA_VIS _LIBCXXABI_DATA_VIS
_LIBCPP_SAFE_STATIC std::unexpected_handler __cxa_unexpected_handler = default_unexpected_handler; _LIBCPP_SAFE_STATIC std::unexpected_handler __cxa_unexpected_handler = default_unexpected_handler;
std::new_handler __cxa_new_handler = 0; _LIBCXXABI_DATA_VIS
_LIBCPP_SAFE_STATIC std::new_handler __cxa_new_handler = 0;
namespace std namespace std
{ {
unexpected_handler unexpected_handler
set_unexpected(unexpected_handler func) noexcept set_unexpected(unexpected_handler func) noexcept
{ {
if (func == 0) if (func == 0)
Show All 21 Lines