This is an archive of the discontinued LLVM Phabricator instance.

Rename llvm.frameescape and llvm.framerecover to localescape and localrecover
ClosedPublic

Authored by rnk on Jul 7 2015, 2:43 PM.

Details

Summary

Initially, these intrinsics seemed like part of a family of "frame"
related intrinsics, but now I think that's more confusing than helpful.
Initially, the LangRef specified that this would create a new kind of
allocation that would be allocated at a fixed offset from the frame
pointer (EBP/RBP). We ended up dropping that design, and leaving the
stack frame layout alone.

These intrinsics are really about sharing local stack allocations, not
frame pointers. I intend to go further and add an llvm.localaddress()
intrinsic that returns whatever register (EBP, ESI, ESP, RBX) is being
used to address locals, which should not be confused with the frame
pointer.

Naming suggestions at this point are welcome, I'm happy to re-run sed.

Diff Detail

Repository
rL LLVM

Event Timeline

rnk updated this revision to Diff 29213.Jul 7 2015, 2:43 PM
rnk retitled this revision from to Rename llvm.frameescape and llvm.framerecover to localescape and localrecover.
rnk updated this object.
rnk added reviewers: majnemer, nicholas.
rnk added a subscriber: llvm-commits.
rnk added a comment.Jul 7 2015, 3:12 PM

David said "just commit it".

This revision was automatically updated to reflect the committed changes.