This is an archive of the discontinued LLVM Phabricator instance.

Differential D109188

[libc++abi] Remove workarounds for missing -Wno-exceptions on older GCCs
ClosedPublic

Authored by ldionne on Sep 2 2021, 1:24 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGd9eb6c7cf55f: [libc++abi] Remove workarounds for missing -Wno-exceptions on older GCCs
Summary

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97675 has now been resolved
in GCC 11, so we can remove those workarounds.

Diff Detail

Event Timeline

ldionne requested review of this revision.Sep 2 2021, 1:24 PM
ldionne created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2021, 1:24 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B122384: Diff 370387.Sep 2 2021, 2:46 PM
ldionne accepted this revision.Sep 3 2021, 11:23 AM
This revision is now accepted and ready to land.Sep 3 2021, 11:23 AM
Closed by commit rGd9eb6c7cf55f: [libc++abi] Remove workarounds for missing -Wno-exceptions on older GCCs (authored by ldionne). · Explain WhySep 3 2021, 11:23 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGd9eb6c7cf55f: [libc++abi] Remove workarounds for missing -Wno-exceptions on older GCCs.

Revision Contents

Diff 370633

libcxxabi/test/catch_class_03.pass.cpp

//===---------------------- catch_class_03.cpp ----------------------------===// //===---------------------- catch_class_03.cpp ----------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
/* /*
This test checks that adjustedPtr is correct as there exist offsets in this This test checks that adjustedPtr is correct as there exist offsets in this
object for the various subobjects, all of which have a unique id_ to object for the various subobjects, all of which have a unique id_ to
check against. check against.
*/ */
// UNSUPPORTED: no-exceptions // UNSUPPORTED: no-exceptions
// FIXME: GCC doesn't allow turning off the warning for exceptions being caught // Compilers emit warnings about exceptions of type 'Child' being caught by
// by earlier handlers, which this test is exercising. We have to disable // an earlier handler of type 'Base'. Congrats, you've just diagnosed the
// warnings altogether to remove the error. // behavior under test.
// See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97675. // ADDITIONAL_COMPILE_FLAGS: -Wno-exceptions
// ADDITIONAL_COMPILE_FLAGS: -Wno-error
#include <exception> #include <exception>
#include <stdlib.h> #include <stdlib.h>
#include <assert.h> #include <assert.h>
// Clang emits warnings about exceptions of type 'Child' being caught by
// an earlier handler of type 'Base'. Congrats clang, you've just
// diagnosed the behavior under test.
#if defined(__clang__)
#pragma clang diagnostic ignored "-Wexceptions"
#endif
struct B struct B
{ {
static int count; static int count;
int id_; int id_;
explicit B(int id) : id_(id) {count++;} explicit B(int id) : id_(id) {count++;}
B(const B& a) : id_(a.id_) {count++;} B(const B& a) : id_(a.id_) {count++;}
~B() {count--;} ~B() {count--;}
}; };
▲ Show 20 Lines • Show All 165 Lines • Show Last 20 Lines

libcxxabi/test/catch_class_04.pass.cpp

//===---------------------- catch_class_04.cpp ----------------------------===// //===---------------------- catch_class_04.cpp ----------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
/* /*
This test checks that adjustedPtr is correct as there exist offsets in this This test checks that adjustedPtr is correct as there exist offsets in this
object for the various subobjects, all of which have a unique id_ to object for the various subobjects, all of which have a unique id_ to
check against. It also checks that virtual bases work properly check against. It also checks that virtual bases work properly
*/ */
// UNSUPPORTED: no-exceptions // UNSUPPORTED: no-exceptions
// FIXME: GCC doesn't allow turning off the warning for exceptions being caught // Compilers emit warnings about exceptions of type 'Child' being caught by
// by earlier handlers, which this test is exercising. We have to disable // an earlier handler of type 'Base'. Congrats, you've just diagnosed the
// warnings altogether to remove the error. // behavior under test.
// See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97675. // ADDITIONAL_COMPILE_FLAGS: -Wno-exceptions
// ADDITIONAL_COMPILE_FLAGS: -Wno-error
#include <exception> #include <exception>
#include <stdlib.h> #include <stdlib.h>
#include <assert.h> #include <assert.h>
// Clang emits warnings about exceptions of type 'Child' being caught by
// an earlier handler of type 'Base'. Congrats clang, you've just
// diagnosed the behavior under test.
#if defined(__clang__)
#pragma clang diagnostic ignored "-Wexceptions"
#endif
struct B struct B
{ {
static int count; static int count;
int id_; int id_;
explicit B(int id) : id_(id) {count++;} explicit B(int id) : id_(id) {count++;}
B(const B& a) : id_(a.id_) {count++;} B(const B& a) : id_(a.id_) {count++;}
~B() {count--;} ~B() {count--;}
}; };
▲ Show 20 Lines • Show All 188 Lines • Show Last 20 Lines

libcxxabi/test/catch_ptr.pass.cpp

//===---------------------- catch_class_04.cpp ----------------------------===// //===---------------------- catch_class_04.cpp ----------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
/* /*
This test checks that adjustedPtr is correct as there exist offsets in this This test checks that adjustedPtr is correct as there exist offsets in this
object for the various subobjects, all of which have a unique id_ to object for the various subobjects, all of which have a unique id_ to
check against. It also checks that virtual bases work properly check against. It also checks that virtual bases work properly
*/ */
// UNSUPPORTED: no-exceptions // UNSUPPORTED: no-exceptions
// FIXME: GCC doesn't allow turning off the warning for exceptions being caught // Compilers emit warnings about exceptions of type 'Child' being caught by
// by earlier handlers, which this test is exercising. We have to disable // an earlier handler of type 'Base'. Congrats, you've just diagnosed the
// warnings altogether to remove the error. // behavior under test.
// See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97675. // ADDITIONAL_COMPILE_FLAGS: -Wno-exceptions
// ADDITIONAL_COMPILE_FLAGS: -Wno-error
#include <exception> #include <exception>
#include <stdlib.h> #include <stdlib.h>
#include <assert.h> #include <assert.h>
// Clang emits warnings about exceptions of type 'Child' being caught by
// an earlier handler of type 'Base'. Congrats clang, you've just
// diagnosed the behavior under test.
#if defined(__clang__)
#pragma clang diagnostic ignored "-Wexceptions"
#endif
struct B struct B
{ {
static int count; static int count;
int id_; int id_;
explicit B(int id) : id_(id) {count++;} explicit B(int id) : id_(id) {count++;}
B(const B& a) : id_(a.id_) {count++;} B(const B& a) : id_(a.id_) {count++;}
~B() {count--;} ~B() {count--;}
}; };
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines

libcxxabi/test/catch_ptr_02.pass.cpp

//===------------------------- catch_ptr_02.cpp ---------------------------===// //===------------------------- catch_ptr_02.cpp ---------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: no-exceptions // UNSUPPORTED: no-exceptions
// FIXME: GCC doesn't allow turning off the warning for exceptions being caught // Compilers emit warnings about exceptions of type 'Child' being caught by
// by earlier handlers, which this test is exercising. We have to disable // an earlier handler of type 'Base'. Congrats, you've just diagnosed the
// warnings altogether to remove the error. // behavior under test.
// See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97675. // ADDITIONAL_COMPILE_FLAGS: -Wno-exceptions
// ADDITIONAL_COMPILE_FLAGS: -Wno-error
// The fix for PR17222 made it in the dylib for macOS 10.10 // The fix for PR17222 made it in the dylib for macOS 10.10
// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.9 // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.9
#include <cassert> #include <cassert>
// Clang emits warnings about exceptions of type 'Child' being caught by
// an earlier handler of type 'Base'. Congrats clang, you've just
// diagnosed the behavior under test.
#if defined(__clang__)
#pragma clang diagnostic ignored "-Wexceptions"
#endif
#if __cplusplus < 201103L #if __cplusplus < 201103L
#define DISABLE_NULLPTR_TESTS #define DISABLE_NULLPTR_TESTS
#endif #endif
struct A {}; struct A {};
A a; A a;
const A ca = A(); const A ca = A();
▲ Show 20 Lines • Show All 188 Lines • Show Last 20 Lines

libcxxabi/test/inherited_exception.pass.cpp

Show All 20 Lines
// o a qualification conversion // o a qualification conversion
// * the handler is a pointer or pointer to member type and E is // * the handler is a pointer or pointer to member type and E is
// std::nullptr_t // std::nullptr_t
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: no-exceptions // UNSUPPORTED: no-exceptions
// FIXME: GCC doesn't allow turning off the warning for exceptions being caught // Compilers emit warnings about exceptions of type 'Child' being caught by
// by earlier handlers, which this test is exercising. We have to disable // an earlier handler of type 'Base'. Congrats, you've just diagnosed the
// warnings altogether to remove the error. // behavior under test.
// See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97675. // ADDITIONAL_COMPILE_FLAGS: -Wno-exceptions
// ADDITIONAL_COMPILE_FLAGS: -Wno-error
// Clang emits warnings about exceptions of type 'Child' being caught by
// an earlier handler of type 'Base'. Congrats clang, you've just
// diagnosed the behavior under test.
#if defined(__clang__)
#pragma clang diagnostic ignored "-Wexceptions"
#endif
#include <assert.h> #include <assert.h>
struct Base { struct Base {
int b1; int b1;
}; };
struct Base2 { struct Base2 {
▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines