Page MenuHomePhabricator

[ConstFolding] Allow constfolding of llvm.sin.* and llvm.cos.* intrinsics
ClosedPublic

Authored by karthikthecool on Jun 30 2015, 3:48 AM.

Details

Summary

Hi All,
This is a minor patch to allow constfolding of llvm.sin* and llvm.cos* intrinsic.
Please let me know if this looks good to be committed into svn.

Thanks and Regards
Karthik Bhat

Diff Detail

Event Timeline

karthikthecool retitled this revision from to [ConstFolding] Allow constfolding of llvm.sin.* and llvm.cos.* intrinsics.
karthikthecool updated this object.
karthikthecool edited the test plan for this revision. (Show Details)
karthikthecool added a reviewer: hfinkel.
karthikthecool added a subscriber: Unknown Object (MLST).
mzolotukhin accepted this revision.Jul 7 2015, 11:39 AM
mzolotukhin added a reviewer: mzolotukhin.
mzolotukhin added a subscriber: mzolotukhin.

Looks good to me.

test/Transforms/InstCombine/intrinsics.ll
22–23

Please don't add empty lines.

452

Another unnecessary empty line.

This revision is now accepted and ready to land.Jul 7 2015, 11:39 AM
This revision was automatically updated to reflect the committed changes.