[ConstFolding] Allow constfolding of llvm.sin.* and llvm.cos.* intrinsics
ClosedPublic
Actions

Authored by karthikthecool on Jun 30 2015, 3:48 AM.

Details

Reviewers

mzolotukhin
hfinkel

Commits

rGd2bc0d842371: Allow constfolding of llvm.sin.* and llvm.cos.* intrinsics This patch const…
rL241665: Allow constfolding of llvm.sin.* and llvm.cos.* intrinsics

Summary

Hi All,
This is a minor patch to allow constfolding of llvm.sin* and llvm.cos* intrinsic.
Please let me know if this looks good to be committed into svn.

Thanks and Regards
Karthik Bhat

Diff Detail

Repository: rL LLVM

Event Timeline

karthikthecool updated this revision to Diff 28767.Jun 30 2015, 3:48 AM

karthikthecool retitled this revision from to [ConstFolding] Allow constfolding of llvm.sin.* and llvm.cos.* intrinsics.

karthikthecool updated this object.

karthikthecool edited the test plan for this revision. (Show Details)

karthikthecool added a reviewer: hfinkel.

karthikthecool added a subscriber: Unknown Object (MLST).

gentle ping...

Looks good to me.

test/Transforms/InstCombine/intrinsics.ll
22–23 ↗	(On Diff #28767)	Please don't add empty lines.
452 ↗	(On Diff #28767)	Another unnecessary empty line.

This revision is now accepted and ready to land.Jul 7 2015, 11:39 AM

Closed by commit rL241665: Allow constfolding of llvm.sin.* and llvm.cos.* intrinsics (authored by karthik). · Explain WhyJul 7 2015, 8:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

lib/

Analysis/

ConstantFolding.cpp

6 lines

test/

Transforms/

InstCombine/

intrinsics.ll

22 lines

Diff 29235

View Options

llvm/trunk/lib/Analysis/ConstantFolding.cpp