Details
- Reviewers
chandlerc reames swaroop.sridhar pgavlin
Diff Detail
Event Timeline
This is looking quite a bit better. I'm going to hold off on accepting this patch until Chandler has had a chance to follow up on http://reviews.llvm.org/D10631, however.
include/llvm/IR/CallSite.h | ||
---|---|---|
119 | From the previous review:
A struct-encapsulated enum or an enum class would also be sufficient. I think any of these choices is a definite step in the right direction. | |
lib/Transforms/Utils/InlineFunction.cpp | ||
151 | It would be good to have a comment describing which classes of statepoints can be inlined, which cannot, if these restrictions can be loosened in the future, and the reasoning behind them. | |
153 | Did you intend SP.gc_args_begin() != SP.gc_args_end()? | |
test/Transforms/Inline/statepoints-basic.ll | ||
63 | s/currenlty/currently |
Some comments addressed. I'll fix the "Extract out StatepointOffsets" bit once we've reached consensus on D10631.
Looks good aside from the pending StatepointOffset refactoring and one small comment.
lib/Transforms/Utils/InlineFunction.cpp | ||
---|---|---|
151 | I'd still like to see some explanation of why the restrictions are there and if they'll be lifted. Doesn't have to be much--even a simple // TODO at the beginning of your existing comment would suffice. |
From the previous review:
A struct-encapsulated enum or an enum class would also be sufficient. I think any of these choices is a definite step in the right direction.