This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] tests/examples for using libFuzzer for out-of-process targets
ClosedPublic

Authored by kcc on Aug 4 2021, 1:33 PM.

Details

Summary

[libFuzzer] tests/examples for using libFuzzer for out-of-process targets

Diff Detail

Event Timeline

kcc requested review of this revision.Aug 4 2021, 1:33 PM
kcc created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 1:33 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kostik accepted this revision.Aug 4 2021, 1:50 PM
kostik added inline comments.
compiler-rt/test/fuzzer/OutOfProcessFuzzTarget.cpp
42

consider adding a small comment for the particular choice of value

46

Generally aren't statics with non-trivial dtors problematic? not sure about the LLVM convention and whether or not you care about such details for the sake of this example

62

nit: libFuzzer

67

consistency nit: (const uint8_t *data, size_t size) seems to be the prevalent signature

This revision is now accepted and ready to land.Aug 4 2021, 1:50 PM
kcc updated this revision to Diff 364269.Aug 4 2021, 3:23 PM

addressed review comments

kcc updated this revision to Diff 364270.Aug 4 2021, 3:25 PM
kcc marked 3 inline comments as done.

addressed one more review comment

kcc marked an inline comment as done.Aug 4 2021, 3:25 PM
kcc added inline comments.
compiler-rt/test/fuzzer/OutOfProcessFuzzTarget.cpp
46

Probably not problematic here, but agree good to not use them for consistency.

kcc updated this revision to Diff 364271.Aug 4 2021, 3:26 PM

fixing incomplete fix, sorry

kcc updated this revision to Diff 364295.Aug 4 2021, 5:12 PM

limit the test to x86_64 linux as it is too experimental to be used elsewhere,
and __libfuzzer_extra_counters are linux-only anyway, currently.

This revision was landed with ongoing or failed builds.Aug 4 2021, 5:37 PM
This revision was automatically updated to reflect the committed changes.