This is an archive of the discontinued LLVM Phabricator instance.

[libc++] add `inline` for __open's definition in ifstream and ofstream
ClosedPublic

Authored by ldionne on Jun 17 2021, 6:24 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Summary

When building with gcc on AIX, it seems that gcc does not like the
always_inline without the inline keyword.
So adding the inline keywords in for open in ifstream and ofstream.
That will also make it consistent with
open in basic_filebuf
(it seems we added inline there before for gcc build as well).

(cherry picked from commit 52e9d80d5db20f23979e409f958736d130387f9e)

Diff Detail

Event Timeline

ldionne requested review of this revision.Jun 17 2021, 6:24 AM
ldionne created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2021, 6:24 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jun 17 2021, 9:44 AM

Associated release blocking bug: http://llvm.org/PR50734

This revision is now accepted and ready to land.Jun 17 2021, 9:44 AM
ldionne closed this revision.Jun 23 2021, 8:42 AM

This has been merged to release/12.x