This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Fix libcxx undefined references
AbandonedPublic

Authored by ldionne on Jun 6 2021, 8:16 PM.

Details

Reviewers
Allen
Summary

Related to the commit 31e82037, and it will bring in link error with some
undefined references if Bootstrap Clang with GCC first, such as
_ZNSt3__112basic_stringIwNS_11char_traitsIwEENS_9allocatorIwEEE6appendEPKwm

Here, if you use tool nm to check the libc++.so.1, the above sample function
is showed with attribute t, which is expected attribute W.

Diff Detail

Event Timeline

Allen requested review of this revision.Jun 6 2021, 8:16 PM
Allen created this revision.

I don't think this is relevant anymore since D103964.

Allen added a comment.Jul 16 2021, 8:00 PM

thanks, D103964 seems a more complete solution include this change, so this can be closed

ldionne commandeered this revision.Jul 28 2021, 9:46 AM
ldionne edited reviewers, added: Allen; removed: ldionne.

Commandeering to abandon.

ldionne abandoned this revision.Jul 28 2021, 9:46 AM