Page MenuHomePhabricator

Fix a few typos and run-on sentences in the clang POD documentation.
ClosedPublic

Authored by gaeke on Jun 4 2015, 12:03 AM.

Details

Diff Detail

Event Timeline

gaeke updated this revision to Diff 27094.Jun 4 2015, 12:03 AM
gaeke retitled this revision from to Fix a few typos and run-on sentences in the clang POD documentation..
gaeke updated this object.
gaeke edited the test plan for this revision. (Show Details)
gaeke added a subscriber: Unknown Object (MLST).Jun 4 2015, 12:03 AM
gaeke set the repository for this revision to rL LLVM.Jun 4 2015, 12:10 AM
majnemer added inline comments.
docs/tools/clang.pod
392

I think this would read better as:

Don't emit any warnings for unused driver arguments.

gaeke added inline comments.
docs/tools/clang.pod
392

Agreed. I will make this change.

gaeke updated this revision to Diff 27616.Jun 12 2015, 4:50 PM

Apply majnemer's edit to the description of -Qunused-arguments.

mclow.lists accepted this revision.Jun 12 2015, 5:05 PM
mclow.lists added a reviewer: mclow.lists.
mclow.lists added a subscriber: mclow.lists.

LGTM.

docs/tools/clang.pod
392

Could just be "Do not emit warnings for unused driver arguments"

Either way is OK, I think - but use "Do not" instead of don't.

This revision is now accepted and ready to land.Jun 12 2015, 5:05 PM
gaeke updated this revision to Diff 27618.Jun 12 2015, 5:14 PM
gaeke edited edge metadata.

Use "Do not" instead of "don't" as suggested by mclow.

compnerd closed this revision.Jun 12 2015, 6:26 PM
compnerd edited edge metadata.

Committed as SVN r239652. Thanks!