This is an archive of the discontinued LLVM Phabricator instance.

Augment the C API
ClosedPublic

Authored by pitrou on Jun 3 2015, 11:28 AM.

Details

Summary

Add a couple simple wrappers to the C API, for the benefit of non-C++ projects.
This represents some of the functionality we expose in the llvmlite Python binding.

Diff Detail

Repository
rL LLVM

Event Timeline

pitrou updated this revision to Diff 27055.Jun 3 2015, 11:28 AM
pitrou retitled this revision from to Augment the C API.
pitrou updated this object.
pitrou edited the test plan for this revision. (Show Details)
pitrou set the repository for this revision to rL LLVM.
pitrou added a subscriber: Unknown Object (MLST).
eliben accepted this revision.Jun 3 2015, 4:50 PM
eliben added a reviewer: eliben.
eliben added a subscriber: eliben.

lgtm

This revision is now accepted and ready to land.Jun 3 2015, 4:50 PM
echristo requested changes to this revision.Jun 4 2015, 5:24 PM
echristo added a reviewer: echristo.
echristo added a subscriber: echristo.

I'm sorry, I'd prefer we not accept this patch today. I'm not a fan of the existing code generation options to LTO and don't want to encompass this sort of thing as top level C API right now.

The symbol patches seem somewhat more reasonable as API and I'm ok with that.

Thanks!

-eric

This revision now requires changes to proceed.Jun 4 2015, 5:24 PM
pitrou updated this revision to Diff 27288.Jun 8 2015, 2:43 AM
pitrou edited edge metadata.

Here is a new patch without the optimization settings APIs.

echristo accepted this revision.Jun 8 2015, 2:31 PM
echristo edited edge metadata.

Seems reasonable.

-eric

This revision is now accepted and ready to land.Jun 8 2015, 2:31 PM
eliben added a comment.Jun 9 2015, 8:35 AM

Do you have commit rights, Antoine?

This revision was automatically updated to reflect the committed changes.