Numba, llvmlite and CPython developer.
- User Since
- Mar 19 2015, 11:27 AM (418 w, 2 d)
Jun 9 2016
Jun 2 2016
I know this patch is a bit hard to swallow given the number of trivial changes in the test suite, but it would be nice to get feedback, at least on the overall approach. As fas as I can tell, the bug is still present in git master.
Thanks, Meador! No, I don't.
Sorry for the ping, but this patch has been marked "accepted and ready to land", and I can't see it on master. Is anything needed on my part?
Feb 15 2016
Is there anything else you want me to do on this patch?
Jan 28 2016
Updated patch folds the change into raw_ostream::operator<<(double N).
Updated against git master.
I think we'd want APFloat::convertFromDecimalString with rmNearestTiesToEven seeing as how we don't expect to see -nan and the like.
Jan 27 2016
(by the way, a related submission awaiting review is at http://reviews.llvm.org/D15375)
Note the test I added to AsmWriterTest.cpp may not be acceptable (as it changes the locale), but it showcases the issue for review.
Jan 26 2016
Ping again :-) This is bitting our users on a regular basis: https://github.com/numba/numba/issues/1656
Jan 7 2016
Just a ping. I'm not sure there's anything holding this patch?
Dec 16 2015
Here is an updated patch without the locale-changing test.
Dec 9 2015
Jun 16 2015
Thanks for committing this, and sorry for the leak!
Jun 9 2015
Jun 8 2015
Here is a new patch without the optimization settings APIs.
Jun 4 2015
Jun 3 2015
Mar 19 2015
I see this issue has generated several changesets. The latest one seems to be rL222897, where only the Large code model avoids truncation. Am I correct in understanding that the JITDefault code model still generates truncations?