Page MenuHomePhabricator

pitrou (Antoine Pitrou)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2015, 11:27 AM (374 w, 3 d)

Numba, llvmlite and CPython developer.

Recent Activity

Jun 9 2016

pitrou added inline comments to D21170: WIP Coroutine Documentation.
Jun 9 2016, 6:24 AM
pitrou added inline comments to D21170: WIP Coroutine Documentation.
Jun 9 2016, 12:42 AM

Jun 2 2016

pitrou added a comment to D16635: Fix PR #12906: printing of floating-point constants on non-C locales.

Hi,
I know this patch is a bit hard to swallow given the number of trivial changes in the test suite, but it would be nice to get feedback, at least on the overall approach. As fas as I can tell, the bug is still present in git master.

Jun 2 2016, 10:44 AM
pitrou added a comment to D15375: Fix PR #25788: parsing of floating-point constants on non-C locales.

Thanks, Meador! No, I don't.

Jun 2 2016, 10:02 AM
pitrou added a comment to D15375: Fix PR #25788: parsing of floating-point constants on non-C locales.

Sorry for the ping, but this patch has been marked "accepted and ready to land", and I can't see it on master. Is anything needed on my part?

Jun 2 2016, 8:22 AM

Feb 15 2016

pitrou added a comment to D16635: Fix PR #12906: printing of floating-point constants on non-C locales.

Hi,
Is there anything else you want me to do on this patch?
Thank you

Feb 15 2016, 9:32 AM

Jan 28 2016

pitrou added inline comments to D16635: Fix PR #12906: printing of floating-point constants on non-C locales.
Jan 28 2016, 1:03 AM
pitrou updated the diff for D16635: Fix PR #12906: printing of floating-point constants on non-C locales.

Updated patch folds the change into raw_ostream::operator<<(double N).

Jan 28 2016, 1:02 AM
pitrou updated the diff for D15375: Fix PR #25788: parsing of floating-point constants on non-C locales.

Updated against git master.

Jan 28 2016, 12:13 AM
pitrou added a comment to D15375: Fix PR #25788: parsing of floating-point constants on non-C locales.

I think we'd want APFloat::convertFromDecimalString with rmNearestTiesToEven seeing as how we don't expect to see -nan and the like.

Jan 28 2016, 12:09 AM

Jan 27 2016

pitrou added a comment to D16635: Fix PR #12906: printing of floating-point constants on non-C locales.

(by the way, a related submission awaiting review is at http://reviews.llvm.org/D15375)

Jan 27 2016, 9:45 AM
pitrou added a comment to D16635: Fix PR #12906: printing of floating-point constants on non-C locales.

Note the test I added to AsmWriterTest.cpp may not be acceptable (as it changes the locale), but it showcases the issue for review.

Jan 27 2016, 9:40 AM
pitrou retitled D16635: Fix PR #12906: printing of floating-point constants on non-C locales from to Fix PR #12906: printing of floating-point constants on non-C locales.
Jan 27 2016, 9:39 AM

Jan 26 2016

pitrou added a comment to D15375: Fix PR #25788: parsing of floating-point constants on non-C locales.

Ping again :-) This is bitting our users on a regular basis: https://github.com/numba/numba/issues/1656

Jan 26 2016, 6:10 AM

Jan 7 2016

pitrou added a comment to D15375: Fix PR #25788: parsing of floating-point constants on non-C locales.

Just a ping. I'm not sure there's anything holding this patch?

Jan 7 2016, 5:51 AM

Dec 16 2015

pitrou updated the diff for D15375: Fix PR #25788: parsing of floating-point constants on non-C locales.

Here is an updated patch without the locale-changing test.

Dec 16 2015, 10:28 AM

Dec 9 2015

pitrou added inline comments to D15375: Fix PR #25788: parsing of floating-point constants on non-C locales.
Dec 9 2015, 11:37 AM
pitrou retitled D15375: Fix PR #25788: parsing of floating-point constants on non-C locales from to Fix PR #25788: parsing of floating-point constants on non-C locales.
Dec 9 2015, 5:19 AM

Jun 16 2015

pitrou added a comment to D10241: Fix returning error message in LLVMLinkModules.

Thanks for committing this, and sorry for the leak!

Jun 16 2015, 2:56 AM

Jun 9 2015

pitrou updated subscribers of D10241: Fix returning error message in LLVMLinkModules.
Jun 9 2015, 12:07 PM

Jun 8 2015

pitrou updated the diff for D10222: Augment the C API.

Here is a new patch without the optimization settings APIs.

Jun 8 2015, 2:43 AM

Jun 4 2015

pitrou retitled D10241: Fix returning error message in LLVMLinkModules from to Fix returning error message in LLVMLinkModules.
Jun 4 2015, 6:02 AM

Jun 3 2015

pitrou retitled D10222: Augment the C API from to Augment the C API.
Jun 3 2015, 11:28 AM

Mar 19 2015

pitrou added a comment to D6079: [x86_64] Don't truncate PC-relative relocations in ELF EH frames to 32 bits.

I see this issue has generated several changesets. The latest one seems to be rL222897, where only the Large code model avoids truncation. Am I correct in understanding that the JITDefault code model still generates truncations?

Mar 19 2015, 11:30 AM