This is an archive of the discontinued LLVM Phabricator instance.

Add tests for full unroll heuristic: folding CFG, folding IVs.
Needs ReviewPublic

Authored by mzolotukhin on Jun 2 2015, 6:27 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

These are the tests for D10205, D10206, and D10207.

Diff Detail

Event Timeline

mzolotukhin updated this revision to Diff 27023.Jun 2 2015, 6:27 PM
mzolotukhin retitled this revision from to Add tests for full unroll heuristic: folding CFG, folding IVs..
mzolotukhin updated this object.
mzolotukhin edited the test plan for this revision. (Show Details)
mzolotukhin added a reviewer: chandlerc.
mzolotukhin added a subscriber: Unknown Object (MLST).
  • Remove a leftover from test.
mzolotukhin updated this revision to Diff 27092.Jun 3 2015, 9:54 PM
  • Add a test for visitICmp fix.
  • Add a test for visitCast fix.
mzolotukhin updated this revision to Diff 27262.Jun 5 2015, 9:11 PM
  • Use new option names.
  • Adjust tests according to the new naming scheme.
  • Add a test to exercise simplifyUsingOffsets.
Gerolf added a subscriber: Gerolf.Jul 7 2015, 9:55 PM
Gerolf added inline comments.
test/Transforms/LoopUnroll/full-unroll-heuristics-cfg.ll
7

Please comment in more detail which cases can be simplified. Are there scenarios with constant loads that won't get simplified?

70

Tthis...

101

1024 (=2^10).
it's -> it is

chandlerc edited edge metadata.Jul 14 2015, 2:45 PM

I agree that these tests can use some more comments to clearly indicate what you expect.

Also, is it possible to isolate a test for the cast folding, put it in the patch with the cast folding? I think then that one would be ready to land. And the CFG tests I'd rather have as part of the CFG folding patch rather than separate.