Refactor: Simplify boolean conditional return statements in lib/Serialization

[LegalizeAdulthood]

Summary

Use clang-tidy to simplify boolean conditional return statements

[LegalizeAdulthood]

Update to latest

[LegalizeAdulthood]

This changeset needs review, but I'm unsure of who to add as explicit reviewers.

lib/Serialization/ASTReader.cpp

while (1) {
         
     case llvm::BitstreamEntry::Record:
       // Ignore top-level records.
       Cursor.skipRecord(Entry.ID);
       break;
         
     case llvm::BitstreamEntry::SubBlock:
       if (Entry.ID == BlockID) {
-        if (Cursor.EnterSubBlock(BlockID))
-          return true;
-        // Found it!
-        return false;
+        return Cursor.EnterSubBlock(BlockID);
       }
       
       if (Cursor.SkipBlock())
         return true;
     }
   }
 }
 

lib/Serialization/ASTWriter.cpp

class ASTIdentifierTableTrait {
   bool NeedDecls;
   ASTWriter::RecordData *InterestingIdentifierOffsets;
   
   /// \brief Determines whether this is an "interesting" identifier that needs a
   /// full IdentifierInfo structure written into the hash table. Notably, this
   /// doesn't check whether the name has macros defined; use PublicMacroIterator
   /// to check that.
   bool isInterestingIdentifier(const IdentifierInfo *II, uint64_t MacroOffset) {
-    if (MacroOffset ||
-        II->isPoisoned() ||
+    return MacroOffset || II->isPoisoned() ||
            (IsModule ? II->hasRevertedBuiltin() : II->getObjCOrBuiltinID()) ||
            II->hasRevertedTokenIDToIdentifier() ||
-        (NeedDecls && II->getFETokenInfo<void>()))
-      return true;
-
-    return false;
+           (NeedDecls && II->getFETokenInfo<void>());
   }
 
 public:
   typedef IdentifierInfo* key_type;
   typedef key_type  key_type_ref;
 
   typedef IdentID data_type;
   typedef data_type data_type_ref;