Page MenuHomePhabricator

Create setting to disable LanguageRuntime provided UnwindPlans
ClosedPublic

Authored by jasonmolenda on Fri, Apr 2, 11:29 PM.

Details

Summary

When developing LanguageRuntime plugin unwind plans, it is sometimes helpful to work with the concrete stacks. This setting allows for that behavior.

Jim, mostly this is a question of the name of the setting, I think. I never know how to name these things, we seem to have a wide variety of setting name styles. I don't know what might be considered better than other possibilities.

Diff Detail

Event Timeline

jasonmolenda created this revision.Fri, Apr 2, 11:29 PM
jasonmolenda requested review of this revision.Fri, Apr 2, 11:29 PM
jingham accepted this revision.Mon, Apr 5, 10:55 AM

This seems okay to me. Putting it in the process is right. We do "disable X" in a bunch of other places when enabled is the default, so that seems right. And I don't think there's much benefit to trying to squeeze the description into fewer letters, since you're either cutting & pasting into a script or using completion anyway.

This revision is now accepted and ready to land.Mon, Apr 5, 10:55 AM
This revision was landed with ongoing or failed builds.Thu, Apr 8, 1:30 PM
This revision was automatically updated to reflect the committed changes.