Send email notification for failures on lldb android builder

[chying]

Summary

• Send email notification to lldb "duty rotation alias" for any failures
• Ignore test failures on android-arm and android-aarch64

[vharron]

zorg/buildbot/builders/LLDBBuilder.py

287 ↗

(On Diff #26366)

I recommend something like:

flunkTestFailure = arch in ('arm', 'aarch64'):

That way, if we add more archs (x86_64 for example) after arm/arm64, it can be set back to true.

[vharron]

Sorry, I mean

# i386/x86_64 are the only android arch that are expected to pass currently
flunkTestFailure = arch in ('i386', 'x86_64'):

[chying]

I think the logic will be the same for x86_64, if it's added later, flunkTestFailure will have its initial value True in the original code.
I agree that the if statement could be eliminated.

[chying]

Simply code based on review feedback

[sivachandra]

LGTM

zorg/trunk/buildbot/osuosl/master/config/status.py

return [
         InformativeMailNotifier(
             fromaddr = "[e-mail]",
             sendToInterestedUsers= False,
             extraRecipients = ["[e-mail]",
                                "[e-mail]"],
             subject="Build %(builder)s Failure",
             mode = "failing",
             builders = ["lldb-x86_64-ubuntu-14.04-cmake",
-                        "lldb-x86_64-darwin-13.4"],
+                        "lldb-x86_64-darwin-13.4",
+                        "lldb-x86_64-ubuntu-14.04-android"],
             addLogs=False,
             num_lines = 15),
         InformativeMailNotifier(
             fromaddr = "[e-mail]",
             sendToInterestedUsers= False,
             extraRecipients = ["[e-mail]",
                                "[e-mail]",
                                "[e-mail]"],
             subject="Build %(builder)s Failure",
             mode = "failing",
             builders = ["clang-x86_64-linux-selfhost-abi-test"],
             addLogs=False,
             num_lines = 15),
         ]

zorg/trunk/zorg/buildbot/builders/LLDBBuilder.py

def getLLDBTestSteps(f,
                      env=None):
     # Skip test steps if no test compiler or arch is specified
     if None in (test_archs, test_compilers):
         return f
     llvm_srcdir = "llvm"
     llvm_builddir = "build"
     if env is None:
         env = {}
+    flunkTestFailure = True
     extraTestFlag = ''
     # TODO: for now, run tests with 8 threads and without mi tests on android
     # come back when those issues are addressed
     testenv=dict(env)
     for compiler in test_compilers:
         # find full path for top of tree clang
         if compiler=='totclang':
             compilerPath=bindir + '/clang'
for compiler in test_compilers:
                                  '--channel ',
                                  '"gdb-remote packets" ',
                                  '--channel ',
                                  '"lldb all"'])
             testname = "local"
             if remote_platform is not None:
                 urlStr='connect://%(remote_host)s:%(remote_port)s'
                 if remote_platform is 'android':
+                    #i386/x86_64 are the only android archs that are expected to pass at this time
+                    flunkTestFailure = arch in ('i386', 'x86_64')
                     testenv['LLDB_TEST_THREADS'] = '8'
                     extraTestFlag = ' -m'
                     urlStr = 'adb://%(deviceid)s:%(remote_port)s'
                     # for Android, remove all forwarded ports before running test
                     # it is noticed that forwarded socket connections were not cleaned for certain crashed tests
                     # clean it here to avoid too many "LISTEN" ports left on slave
                     f.addStep(ShellCommand(name="remove port forwarding %s" % arch,
                                            command=['adb',
for compiler in test_compilers:
                 testname = "remote-" + remote_platform
             DOTEST_OPTS += extraTestFlag
             f.addStep(LitTestCommand(name="test lldb %s (%s-%s)" % (testname, compiler, arch),
                                      command=['../%s/tools/lldb/test/dosep.py' % llvm_srcdir,
                                               '--options',
                                               WithProperties(DOTEST_OPTS)],
                                      description="test lldb",
                                      parseSummaryOnly=True,
+                                     flunkOnFailure=flunkTestFailure,
+                                     warnOnFailure=flunkTestFailure,
                                      workdir='%s' % llvm_builddir,
                                      env=testenv))
             f=cleanSVNSourceTree(f, '%s/tools/lldb' % llvm_srcdir)
     return f
 
 # Define a structure to describe remote target
 # For example, RemoteConfig('linux','x86_64',['gcc4.8.2','clang'],['i386'])
 RemoteConfig = collections.namedtuple("RemoteConfig", ["platform", "host_arch", "test_compilers", "test_archs"])