This is an archive of the discontinued LLVM Phabricator instance.

Add real time signals signals to LinuxSignals
ClosedPublic

Authored by labath on May 21 2015, 7:15 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 26240.May 21 2015, 7:15 AM
labath retitled this revision from to Add real time signals signals to LinuxSignals.
labath updated this object.
labath edited the test plan for this revision. (Show Details)
labath added reviewers: tberghammer, ovyalov.
labath added a subscriber: Unknown Object (MLST).
tberghammer accepted this revision.May 21 2015, 7:32 AM
tberghammer edited edge metadata.

Looks good

test/functionalities/signal/raise/TestRaise.py
22 ↗(On Diff #26240)

I would prefer to see 2 separate test cases for this (with passing / waithout passing) where one of them is XFAIL-ed because grep-ing for this comment is a bit difficult

This revision is now accepted and ready to land.May 21 2015, 7:32 AM
labath added inline comments.May 21 2015, 7:54 AM
test/functionalities/signal/raise/TestRaise.py
22 ↗(On Diff #26240)

It's not really clear what is the correct behavior in this case or how to write a test for it. You would need to "resume" (from the ptrace-stop) the inferior but keep it stopped (in the normal SIGSTOP sense) and have it wait until it receives a SIGCONT. This is quite an obscure feature, which i don't think we'll support in the near future. I can make it a bit more visible by adding a dummy @expectedFailure, but that's all it deserves i think.

tberghammer added inline comments.May 21 2015, 8:08 AM
test/functionalities/signal/raise/TestRaise.py
22 ↗(On Diff #26240)

If that case isn't clear then just leave it as it is now and we will create a test when we know what is the expected behavior.

This revision was automatically updated to reflect the committed changes.