[Object][MachO] Handle end iterator in getSymbolType()

[steven_wu]

Summary

Fix a bug in MachOObjectFile::getSymbolType() that it is not checking if
the iterator is end() before deference the iterator. Instead, return
Other type, which aligns with the behavior of llvm-nm.

rdar://75291638

[davide]

Sure.

llvm/lib/Object/MachOObjectFile.cpp

MachOObjectFile::getSymbolType(DataRefImpl Symb) const {
   switch (n_type & MachO::N_TYPE) {
     case MachO::N_UNDF :
       return SymbolRef::ST_Unknown;
     case MachO::N_SECT :
       Expected<section_iterator> SecOrError = getSymbolSection(Symb);
       if (!SecOrError)
         return SecOrError.takeError();
       section_iterator Sec = *SecOrError;
+      if (Sec == section_end())
+        return SymbolRef::ST_Other;
       if (Sec->isData() || Sec->isBSS())
         return SymbolRef::ST_Data;
       return SymbolRef::ST_Function;
   }
   return SymbolRef::ST_Other;
 }
 
 Expected<uint32_t> MachOObjectFile::getSymbolFlags(DataRefImpl DRI) const {