This is an archive of the discontinued LLVM Phabricator instance.

[RGT] RPCUtilsTest, replace un-executed EXPECT with unreachable
ClosedPublic

Authored by probinson on Mar 12 2021, 8:49 AM.

Details

Summary

Unreachable code should be self-documented as unreachable.

Found by the Rotten Green Tests project.

Diff Detail

Event Timeline

probinson requested review of this revision.Mar 12 2021, 8:49 AM
probinson created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2021, 8:49 AM
lhames accepted this revision.Mar 15 2021, 8:30 PM

LGTM. Thanks Paul!

(If you don't have commit access already just let me know and I can land this on your behalf)

This revision is now accepted and ready to land.Mar 15 2021, 8:30 PM
This revision was landed with ongoing or failed builds.Mar 17 2021, 7:38 AM
This revision was automatically updated to reflect the committed changes.