This is an archive of the discontinued LLVM Phabricator instance.

Differential D97932

[asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris
ClosedPublic

Authored by ro on Mar 4 2021, 4:16 AM.

Details

Reviewers
vitalybuka
Commits
rG1d0dee51daaf: [asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris
Summary

One ASan test currently XPASSes on Solaris:

AddressSanitizer-i386-sunos :: TestCases/Posix/no_asan_gen_globals.c

It was originally XFAILed in D88218 because Solaris ld, unlike GNU ld, doesn't
strip local labels. Since then, the integrated assembler has stopped emitting those
local labels, so the difference becomes moot and the XFAIL can go.

Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu.

Diff Detail

Event Timeline

ro created this revision.Mar 4 2021, 4:16 AM
Herald added subscribers: pengfei, fedor.sergeev. · View Herald TranscriptMar 4 2021, 4:16 AM
ro requested review of this revision.Mar 4 2021, 4:16 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptMar 4 2021, 4:16 AM
vitalybuka accepted this revision.Mar 4 2021, 1:34 PM
This revision is now accepted and ready to land.Mar 4 2021, 1:34 PM
Harbormaster completed remote builds in B92038: Diff 328121.Mar 4 2021, 3:06 PM
Closed by commit rG1d0dee51daaf: [asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris (authored by ro). · Explain WhyMar 5 2021, 12:43 AM
This revision was automatically updated to reflect the committed changes.
ro added a commit: rG1d0dee51daaf: [asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris.

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
Posix/
2 lines

Diff 328418

compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c

// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316 // FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
// XFAIL: android // XFAIL: android
// Bug 47607
// XFAIL: solaris
// Make sure ___asan_gen_* strings do not end up in the symbol table. // Make sure ___asan_gen_* strings do not end up in the symbol table.
// RUN: %clang_asan %s -o %t.exe // RUN: %clang_asan %s -o %t.exe
// RUN: nm %t.exe | FileCheck %s // RUN: nm %t.exe | FileCheck %s
int x, y, z; int x, y, z;
int main() { return 0; } int main() { return 0; }
// CHECK-NOT: ___asan_gen_ // CHECK-NOT: ___asan_gen_